The commerce_decimal_quantities module dose not work with kickstart see #1961364: Compatibility with Commerce Kickstart 2 this is because the "Commerce Kickstart Product UI" module takes control of the form quantity element and provides no configuration to turn it off.
It would be great if we had an option on the bundle page that controls this (like the decimal quantities does). This will allow users to select the functionality they need.
Will be happy to have a go at a patch if you are convinced this is a good idea.

CommentFileSizeAuthor
#4 make_spinner_js-2061473-4.patch1.6 KBmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

guy_schneerson’s picture

guy_schneerson CreditAttribution: guy_schneerson commented

also related to #2053811: Commerce Kickstart Product UI module improvements

lsolesen’s picture

lsolesen CreditAttribution: lsolesen commented
Issue summary: View changes

Kickstart should not make other module incompatible. Could you explain exactly how to reproduce and what to look for

lsolesen’s picture

lsolesen CreditAttribution: lsolesen commented
Status: Active » Postponed (maintainer needs more info)
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Postponed (maintainer needs more info) » Needs review
FileSize
make_spinner_js-2061473-4.patch1.6 KB

New variable: commerce_kickstart_product_ui_spinner_disable, set to "TRUE" to disable. Other option is to hook_commerce_cart_add_to_cart_form_alter() and remove the library from #attached.

Build: https://travis-ci.org/commerceguys/commerce_kickstart/builds/72198587

  • mglaman committed bb48143 on 7.x-2.x 
    Merge pull request #142 from mglaman/2061473-allow-spinner-disable...
  • mglaman committed eb126f6 on 7.x-2.x
    Issue #2061473: Make spinner JS configurable so module plays nicely with...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs review » Fixed
guy_schneerson’s picture

guy_schneerson CreditAttribution: guy_schneerson commented

Hi @mglaman & @lsolesen
Sorry I haven't replied, missed it somehow, but looks like @mglaman figured it out.
Thanks for sorting out :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.