Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
(Follow-up of http://drupal.org/node/1728106#comment-6997826)
There's a major design flaw in the way the callback-based method is implemented :
The 'switch/case' statement that give the callback a chance to be called actually resides in an if statement conditioned by the existence of some past invoices.
As a result the callback is never called if no invoice exists.
Here's a patch that move the callback logic outside this statement as the check of past invoice is in the scope of the numbering strategy itself, IMHO.
Comment | File | Size | Author |
---|---|---|---|
#1 | Invoice_number_generation_is_broken-1928798-1.patch | 1.69 KB | garphy |
Comments
Comment #1
garphy CreditAttribution: garphy commentedPatch attached.
Comment #2
C-Logemanntry to trigger the test system.
Comment #3
cspitzlay@garphy: I will test your patch soon.
Comment #4
cspitzlayI just committed it.
Thanks for catching that issue and for the patch.
Comment #5
attiks CreditAttribution: attiks commentedDid you forget to push, I don't see the commit?
Comment #6
attiks CreditAttribution: attiks commentednvm, found it