Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We're unable to get a Project Update Bot scan working on dev at the moment because of an upstream infrastructure issue (#3327925: Missing bcmath PHP extension for projects extending Drupal Commerce).
Drupal 10 support would need to be addressed manually until that issue is fixed upstream.
Comment | File | Size | Author |
---|---|---|---|
#24 | commerce-google-tag-manager-3340566-24.patch | 6.58 KB | manojbisht_drupal |
#23 | commerce-google-tag-manager-3340566-23.patch | 7.54 KB | manojbisht_drupal |
#6 | commerce_gtm_d10.patch | 6.24 KB | J. |
Issue fork commerce_google_tag_manager-3340566
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
J. CreditAttribution: J. commentedSame question.
Comment #4
codebymikey CreditAttribution: codebymikey at Zodiac Media commentedComment #5
codebymikey CreditAttribution: codebymikey at Zodiac Media commentedComment #6
J. CreditAttribution: J. commentedHere's a patch for D10 compatability. I've manually tested in on 9.5 w/php8.1 and was able to send events to GTM. I had no problems manually testing it on D10 either.
Comment #7
RgnYLDZ CreditAttribution: RgnYLDZ commentedHow can I test the module for D10? I cannot get it with composer. I like to test it.
Or can we have a dev version?
Comment #8
rsnyd@J.,
Is this for 8.x-2.x-dev? I'm getting a .rej for the patch in #6.
Comment #9
rsnydAttempting a patch based on upgrade_status suggestions.
Comment #10
J. CreditAttribution: J. commentedYes it was for 8.x-2.x-dev.
Comment #12
o_timoshchuk CreditAttribution: o_timoshchuk at DevBranch commentedIn D10 I installed "drupal/commerce_google_tag_manager": "^2.0@beta" and applied patch #6.
I have tested the module and it is functioning properly.
Comment #15
richgerdesThe two above branches are functionally the same.
https://git.drupalcode.org/issue/commerce_google_tag_manager-3340566/-/c...
I think MR 7 follows the code standards a little closer, and probably should be the candidate merged.
Comment #16
newaytech CreditAttribution: newaytech commentedThanks for the great module folks and support in bringing up to date for D10. Do we have an ETA for a new release with D10 support baked in?
Comment #17
sagesolutions CreditAttribution: sagesolutions commented+1 for having a new release with D10 supported!
Comment #18
rsnyd+1 for having a new release with D10 supported!
Comment #19
newaytech CreditAttribution: newaytech commentedFor anyone else landing here - for what it's worth - I rewrote a few GTM triggers and am now using the Google Tag module (the new version now supports GTM - and has a pretty good ecomm dataLayer). I thought that updating the module with the version numbers would work (thanks for the patch) - but the composer.json file looks at the GIT repo for compatibility.
Comment #20
jcmartinezAfter applying the patch #9, I got a WSOD with the following error message:
Comment #21
leymannxTo tell Composer to not look at the package for compat you need to use the composer-lenient-plugin. See https://www.drupal.org/docs/develop/using-composer/using-drupals-lenient....
composer require mglaman/composer-drupal-lenient
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/commerce_google_tag_manager"]'
composer install
Comment #22
leymannxLooks like there are still a few more problems: https://dev.acquia.com/drupal10/deprecation_status/projects/commerce_goo...
Comment #23
manojbisht_drupal CreditAttribution: manojbisht_drupal as a volunteer and commentedAdding the patch, as it is dependent on google_tag 2.0.
Comment #24
manojbisht_drupal CreditAttribution: manojbisht_drupal as a volunteer and commentedRewriting patch after removing test case