Problem/Motivation

Under Analytics reports, it's currently associating "Product SKU" with the product ID and not the variation SKU. Which isn't very useful.

Proposed resolution

I suggest using the product variation SKU if it's available.

CommentFileSizeAuthor
#8 use-product-variation-sku-if-available-3066949-8.patch11.15 KBAerzas
#7 use-product-variation-sku-if-available-3066949-7-alpha3.patch715 bytescbildstein
#6 use-product-variation-sku-if-available-3066949-6-alpha2.patch741 bytessmccabe
#5 use-product-variation-sku-if-available-3066949-5.patch715 bytessmccabe
#2 use-product-variation-sku-if-available-3066949-2.patch616 bytescbildstein
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cbildstein created an issue. See original summary.

cbildstein’s picture

cbildstein CreditAttribution: cbildstein at Acro Commerce commented
FileSize
use-product-variation-sku-if-available-3066949-2.patch616 bytes

Patch for using the variation SKU if it's available.

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
CreditAttribution: wengerk at Antistatique commented

Many thanks for your contribution.

It seems the change break our tests (which is good - it means we cover the case).
May you update the tests strategy in the patch ?

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
CreditAttribution: wengerk at Antistatique commented
Status: Active » Needs work
Issue tags: +Needs tests
smccabe’s picture

smccabe CreditAttribution: smccabe as a volunteer and at Acro Commerce commented
FileSize
use-product-variation-sku-if-available-3066949-5.patch715 bytes

Re-roll

smccabe’s picture

smccabe CreditAttribution: smccabe as a volunteer and at Acro Commerce commented
FileSize
use-product-variation-sku-if-available-3066949-6-alpha2.patch741 bytes

Re-roll against specifically against alpha2 as well, if anyone is using this patch currently.

cbildstein’s picture

cbildstein CreditAttribution: cbildstein at Acro Commerce commented
FileSize
use-product-variation-sku-if-available-3066949-7-alpha3.patch715 bytes

Alpha3 patch re-roll.

Aerzas’s picture

Aerzas CreditAttribution: Aerzas at Watch Dreamer SA for Watch Dreamer SA commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
use-product-variation-sku-if-available-3066949-8.patch11.15 KB

Here is an update of the patch against the `8.x-2.x-dev` branch:
- Removed the condition as the `sku` is required for a product variation to be valid
- Updated unit, kernel and functional tests

agoradesign’s picture

agoradesign CreditAttribution: agoradesign commented

+1 for this change!

The premium solution would make this behaviour configurable, making it easier to stay BC (however we're in beta version, so we don't have to worry too much about this). But one thing that would be nice: firing a dedicated Drupal/Symfony event for altering the ID key (for products and any other purchasable entity), if any custom solution is needed. Right now we could do this with AlterEventDataEvent, but this can be a little bit cumbersome, as we only have the GTM event data there without any context