In swedbank new document v1.4. There is an update. "Added responsibility to check DATETIME value, which may not differ from the current time at the moment of checking more than ± 5 minutes.". Currently in "banklink_verify_signature()" function, I can not find such checking.

https://www.swedbank.ee/static/pdf/business/d2d/paymentcollection/Pangal...

Your thoughts on this? Should it be patched. Am I understanding this wrong?

Comments

ram4nd created an issue. See original summary.

Martin.’s picture

Martin. CreditAttribution: Martin. at ADM Interactive commented

Whether it's required or not is irrelevant because all iPizza protocol banklinks in this module include VK_DATETIME propery in their requests and therefor it changes nothing. Unless you have an actual bug with banklinks not working I am marking this as fixed.

EDIT: I should specify that I am talking about the 2.x branch.

Martin.’s picture

Martin. CreditAttribution: Martin. at ADM Interactive commented
Status: Active » Closed (works as designed)
Martin.’s picture

Martin. CreditAttribution: Martin. at ADM Interactive commented

Ok I misunderstood the question at first, but still the check is being made in banklink_verify_signature(). It's the VK_T_DATETIME parameter.

ram4nd’s picture

ram4nd CreditAttribution: ram4nd as a volunteer commented
Status: Closed (works as designed) » Active

Yes it is put in the array, but the point is that it's not tested for being in between ± 5 minutes...