This is dependent on #2730365: Return the line item updated in commerce_discount_set_existing_line_item_price() and #2730369: Return the line item created in commerce_discount_add_line_item() and will allow modules to make additional adjustments to the discount line item created out of BOGO offers.

CommentFileSizeAuthor
#6 2730371-6.discounted_line_item_alter.patch4.26 KBrszrama
#5 2730371-5.discounted_line_item_alter.patch3.04 KBrszrama
#2 2730371.discounted_line_item_alter.patch2.53 KBrszrama
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rszrama created an issue. See original summary.

rszrama’s picture

rszrama CreditAttribution: rszrama at Centarro for DPCI commented
Status: Active » Needs review
FileSize
2730371.discounted_line_item_alter.patch2.53 KB

Still needs docs in .api.php but otherwise ready for review / testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for DPCI commented
Status: Needs review » Needs work 
+++ b/commerce_discount_extra.rules.inc
@@ -593,10 +599,16 @@ function commerce_discount_extra_per_quantity_category_discount(EntityDrupalWrap
+    $discount_line_item = commerce_discount_set_existing_line_item_price($order_wrapper, $discount_name, $discount_price)

;!

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro for DPCI commented

Also.. should it be an invoke? Modules implementing the alter will need to save. Alter has the context you are modifying before save, or the lack of needing to save.

rszrama’s picture

rszrama CreditAttribution: rszrama at Centarro for DPCI commented
Status: Needs work » Needs review
FileSize
2730371-5.discounted_line_item_alter.patch3.04 KB

You're right, changed it to a normal invoke with our own saving logic.

rszrama’s picture

rszrama CreditAttribution: rszrama at Centarro for DPCI commented
FileSize
2730371-6.discounted_line_item_alter.patch4.26 KB

Final pass with API docs.

rszrama’s picture

rszrama CreditAttribution: rszrama at Centarro for DPCI commented
Status: Needs review » Fixed

Committed!

  • rszrama committed 4ae0ca7 on 7.x-1.x 
    Issue #2730371 by rszrama, mglaman: Add a hook to alter line items...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.