Cart Refresh check for discount price components causes Coupon removal

Can confirm that I am having the same issue using Commerce Discount 1.0-alpha7 and the latest dev release of Commerce Coupon. I also don't even have #1268472: Recursion in price calculation causes cart to skip calculation rules applied, but it may have something else to do with my setup.

For the time being, I've been forced to comment out most of the logic in commerce_coupon_commerce_cart_order_refresh(), which is far from ideal, but solves the problem for now as I have a client trying to run a Black Friday sale.

With a temporary fix in place, I'll now try to investigate this further to come up with a better solution.

@torgosPizza I am indeed running a version of Commerce Discount with the "compatibility settings" feature. Like you, I also seem to have come to conclusion that it has some issues. I'm also having trouble with product discounts; I haven't done much testing with order discounts yet.

One thing I did notice is that the commerce_discount_compatibility_check() function sets a $applied_discounts variable by calling commerce_discount_get_discounts_applied_to_price(), and the discount that is being checked for compatibility is sometimes included IN the list of applied discounts.

This causes the compatibility check to fail when the discount has compatibility settings configured on it, because it ends up conflicting with itself! I.e. it thinks that another discount has already been applied to the order, and removes itself.

I'm currently testing out a figure where I add the following code:

foreach ($applied_discounts as $applied_discount_id => $applied_discount_name) {
    if ($applied_discount_name == $discount_name) {
      unset($applied_discounts[$applied_discount_id]);
    }
  }

right before this line:

// Ensure none of them indicate they are incompatible with the current one.
  foreach ($applied_discounts as $applied_discount_id => $applied_discount_name) {

In the commerce_discount_compatibility_check().

So far, this seems to have solved the issue of the discount disappearing and the coupon being removed, but I need to do some more testing to be sure. It doesn't really seem like a very elegant solution, either.

@torgosPizza We're using a fairly custom set up, so I've got to try and take some time today or tomorrow to get a better list of steps to reproduce using Commerce Kickstart. For our set up, we just have do create a product discount tied to a coupon, and that's enough to start causing problems during checkout where the coupon/discount disappears.

Using the fix I noted above, I was able to stop the coupon/discount from disappearing, but we still had all kinds of issues with the "compatibility" settings in the latest version of Commerce Discount. We had to change all of our discounts back to the default "compatible with all other discounts" options to have the discounts work correctly.

I've used the fix in #4 to fix the same issue with coupons dropping off orders at the review stage.

It seems to be working for now. Should we get this into a patch?

I've attached a patch.

Confirmed working with latest dev and latest dev of commerce coupons.

I confirm that #10 solves my issue as announced.
I confirmed that the patch mentionned at #11 works also.

from the patch it looks it should be on Commerce Discount issue queue not Commerce Coupon.

Patch in #10 the comment says to make sure discount is not removed, and what it does is unset/remove them... this is bizarre, could you explain?

Patch from comment#10 works form me in 7.x.1.0-alpha8 module version.
In my case i lost information about discount for product on cart/checout page refresh.

not working for me with latest devs of both

All patches apply against dev

the patch applies fine - it just doesn't resolve the issue. I'm running the latest devs of discount and coupon
i'm going to try a fresh install and see whether the patch referenced in #11 solves it

If I'm not mistaken, #2621526: Compatibility settings other than "all" causes Discount+Coupon to be removed seems to have resolved this issue as a side effect. I just attempted the OP to reproduce the bug and my coupon remained even after visiting the product page and adding to cart again.

If someone else can test this, just move to "Closed (outdated)" if you confirm it's resolved.

Tested with latest versions of commerce, discount and coupon

Scenario:
- Order discount A with a coupon
- Order discount B without a coupon

Whenever commerce_discount_commerce_cart_order_refresh get called the discount reference on the order to B is removed,

rules_invoke_event('commerce_discount_order', $order_wrapper); triggers the executing of both rules for A and B, but only the reference to A is saved on the order

#20 This is caused by another error

commerce_discount_percentage contains the following line

      $delta = $wrapper->commerce_discounts->count();
      $order->commerce_discounts[LANGUAGE_NONE][$delta]['target_id'] = $discount_wrapper->discount_id->value();

if you change it to

      $order->commerce_discounts[LANGUAGE_NONE][]['target_id'] = $discount_wrapper->discount_id->value();

the reference stays, so this problem was caused by the offer type, I'll create a new issue

Patch at #2940086-2: Offer type code depends on discount reference being set

Back to NR