Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
i think this would give a better dx with cleaner modules to start with.
or do many people want a combined-fixed-plus-variable coupon?
Comment | File | Size | Author |
---|---|---|---|
#7 | 1372434-move_pct_and_fixed_amount-7.patch | 28.07 KB | pcambra |
#6 | 1372434-move_pct_and_fixed_amount-6.patch | 8.48 KB | pcambra |
#5 | 1372434-move_pct_and_fixed_amount-5.patch | 8.5 KB | pcambra |
#4 | 1372434-move_pct_and_fixed_amount-4.patch | 8.35 KB | pcambra |
#3 | 1372434-move_pct_and_fixed_amount.patch | 5.98 KB | pcambra |
Comments
Comment #1
geek-merlinbattle plan:
* copy basic_coupon to fixed_coupon and percentage_coupon
(leave basic coupon for a smooth upgrade)
* get the names of the functions right
* throw out in each of the two new modules what isn't needed
Comment #2
pcambra+1 to this
Comment #3
pcambraWorking on it. I'm separating the fixed and percentage coupons in two modules.
http://drupal.org/sandbox/pcambra/1454380
http://drupal.org/sandbox/pcambra/1454390
And patch attached to standarize
Comment #4
pcambraPushed refresh support for fixed amounts and also one component price per coupon when fixed.
Comment #5
pcambraRebased against latest head.
Comment #6
pcambraLittle tweaks after fixing active flag
Comment #7
pcambraFinished the upgrade path from basic coupons to fixed/percentage
I was going to promote the sandboxes to full projects and committing this but had some strange problem: []
Attaching the latest patch.
Comment #8
fearlsgroove CreditAttribution: fearlsgroove commented@pcambra -- sorry haven't reviewed your patches yet but I'm looking forward to this. You mentioned promoting sandbox projects. Do you envision the fixed/percentage coupons be available only as separate projects, or rolled into "contrib" modules in this project?
Comment #9
pcambraOops, I forgot to paste the issue reference #1483876: Promoted full projects merged
As soon as that one gets resolved, I'll promote fixed and pct as independent projects and commit all this together.
Comment #10
pcambraAnswering more clearly, there won't be a contrib folder anymore on this project, same as shipping.
Comment #11
pcambraAnd commited!
Comment #12
geek-merlincool you dunnit!
(i'm so stuck in other projects, but cant await to check it out.)
Comment #13
kiwimind CreditAttribution: kiwimind commentedThanks pcambra. Can't wait to try this out!
Comment #14
muschpusch CreditAttribution: muschpusch commented@Pcambra: thanks a lot. i use a heavily patched version at the moment and it still has some flaws. Is the current dev release usable for percentage and fixed coupons?
Comment #15
pcambraAbsolutely, last -dev doesn't have either pct coupons or fixed amount ones, you'll need the those new modules to get something working :)
Comment #17
AdamGerthel CreditAttribution: AdamGerthel commentedIs there an upgrade path? What happens to current coupons if you use start using the new, separated modules instead of the old combined one?
Comment #18
pcambraYes, you'll find an upgrade form in the Settings screen of commerce coupon