This patch provides deep module elaboration and integrates standard drupal login and registration forms into checkout pane instead of using custom forms with custom logic. This solves problem with incompatibility with many thrid-party modules that reform standard user forms in hook_form_alter: e-mail registration, uLogin, HybridAuth & so on. In my mind integrating of standard forms would be better solution than manually reproduction of its behavior.

CommentFileSizeAuthor
#12 use_core_login_registration_form-2874884-12.patch27.82 KBcosolom
#10 use_core_login_registration_form-2874884-10.patch25.93 KBcosolom
#5 checkout-login.jpg107.39 KBshi99
#2 commerce_checkout_login-standard_user_forms-2874884-#2-7.x-2.x.patch35.88 KBStrVL

Comments

StrVL created an issue. See original summary.

StrVL’s picture

StrVL commented
StatusFileSize
new commerce_checkout_login-standard_user_forms-2874884-#2-7.x-2.x.patch35.88 KB
StrVL’s picture

StrVL commented
Status: Active » Needs work
StrVL’s picture

StrVL commented
Status: Needs work » Needs review
shi99’s picture

shi99 commented
StatusFileSize
new checkout-login.jpg107.39 KB

Thanks for the patch. I needed the standard registration form on the checkout and this seems to work.

One thing about the display.
The login and register forms are structured under the "select" container. But when they it is rendered, the login form is rendered within the select container and the registration form is rendered outside of it in it's own fieldset.

This means the two forms won't sit side by side with the help above it.
See attached image to see the HTML

Thanks

shi99’s picture

shi99 commented

Ignore my last comment. The issue was related to a mistake in my HTML in my template.
both forms are now correcty contained within the same "select" container.

Thanks

nick_sh’s picture

nick_sh commented

Not compatible with the latest version of module. Please, could you update this patch?

mibfire’s picture

mibfire commented

Why don't module maintainers respond to this? when this should have been the original solution from the beginning.

solideogloria’s picture

solideogloria commented

The patch probably needs a reroll.

cosolom’s picture

cosolom commented
StatusFileSize
new use_core_login_registration_form-2874884-10.patch25.93 KB

This will be good start point. It works, but not sure that I remove all redundant functions and I not checked logic and complex errors. Also if will be enabled antibot module maybe will some troubles with checkout. Also tests need update too.

Status: Needs review » Needs work

The last submitted patch, 10: use_core_login_registration_form-2874884-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

cosolom’s picture

cosolom commented
StatusFileSize
new use_core_login_registration_form-2874884-12.patch27.82 KB

This is with fixed code styles. But work still needs