Needs review
Project:
Commerce Checkout Login
Version:
7.x-2.0-beta1
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
4 May 2016 at 10:09 UTC
Updated:
10 Mar 2021 at 21:48 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
legolasboAdding this to the roadmap for 7.x-2.x
Comment #3
larynThis is my fix for the issue. Basically logged in users got stranded on the "Account info" pane -- I just got rid of the "Account info" pane if a user is logged in. Maybe helpful to someone else.
Comment #4
kcannick commentedWow... This should be committed. Customers were unable to check out for 4 days and I spent an extra day thinking I misconfigured something.
Comment #5
arnaud.dabouis commentedThis patch also removes ability to configure the checkout steps.
Comment #6
legolasboThis patch is not the correct solution. A better solution 'to get rid of the account pane' would be to just return an empty form if the user is logged in. Still better would be to just show the account details instead of a form.
Comment #7
legolasboAlso, I would like to see automated tests for this.
Comment #8
arnaud.dabouis commentedThis patch fixes the issue. Tell me if it breaks anything.
Comment #9
arnaud.dabouis commentedComment #10
legolasboDoesn't break any existing tests, but the new functionality is not covered by the existing tests. Please add test coverage for this.
Comment #11
caschbre commentedQuestion... is there a reason to even show this checkout page if the user is already logged in and not simply redirect them to the next checkout page?
Comment #12
spidersilk commentedDealing with this issue too. Caschbre's point is a good one - why even have the account info page, rather than taking them directly to the checkout process as you'd expect?
Comment #13
spidersilk commentedThe patch in #8 worked for me!
Comment #14
jaguero commented#8 works, but hides the configuration form in admin area.
Old:
if (user_is_logged_in()) {
New:
if (user_is_logged_in() && !path_is_admin(current_path())) {
Comment #15
mrwconnected commentedAgree, this is not a great experience for the user. Why not just direct them to checkout?
Comment #16
matthiasm11 commentedI think we should not redirect the user, since we are going through the checkout progress step by step.
The account information page confirms to the user which account he is using at the moment.
Updatet the patch from #8 with the comment from #14.
Comment #17
matthiasm11 commentedComment #18
solideogloria commented"Critical" means data is corrupted. Changing to Major.