This is a pretty minor issue for a bit of an edge case, but I noticed that if I initially enter information to register an account, go to the next step, but then go back to the first step and log in (without deliberately deleting the registration info), both the logged-in user information and the new user information is shown in the "Account information" pane on the next step. It appears that the order is attached to the log in user, but the UI would be a bit confusing in this case.

Checking for the logged in user and removing the register info for the Account information pane would be helpful.

CommentFileSizeAuthor
#9 commerce_checkout_login-remove_new_account_info-2682239-9.patch2.83 KBsano
#6 commerce_checkout_login-remove_new_account_info-2682239-6.patch2.84 KBsgdev
#3 commerce_checkout_login-7.x-2.0-beta1---issue_2682239.patch2.57 KBbensey

Comments

spazfox created an issue. See original summary.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Parent issue: » #2580227: [META] 2.0 release

Adding this to the roadmap for the next beta.

bensey’s picture

bensey commented
StatusFileSize
new commerce_checkout_login-7.x-2.0-beta1---issue_2682239.patch2.57 KB

I wouldn't have said it was a minor issue myself, this was a usage dealbreaker for me.
If a customer proceeds through using "register" then hits back and decides they want to go through as "guest", it still shows them the info about creating an account, and is still going to create an account. And as mentioned above if the user then logs in, it displays both account information and register information, super confusing for the end user...

Anyways, I really like this login/register/guest checkout workflow so I've had a crack at a patch. Seems to fix the issues for me.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Active » Needs review
Issue tags: +Needs tests

Setting to needs review to see what testbot thinks about your changes.

Besides that I would like to see this use-case covered by tests as well to make sure this continues working as expected.

matthiasm11’s picture

matthiasm11 commented

Patch still applies against beta2.

sgdev’s picture

sgdev commented
Version: 7.x-2.0-beta1 » 7.x-2.x-dev
StatusFileSize
new commerce_checkout_login-remove_new_account_info-2682239-6.patch2.84 KB

The patch in #3 does not apply cleanly unless adding the patch manually. It references a module folder of commerce_checkout_login_new, which it should not do. This will cause errors, especially if applying the patch using an IDE.

The attached version cleans up these issues. Please review, thanks.

Anonymous’s picture

Anonymous (not verified) commented

Patch #6 does not apply to current dev 7.x-2.0-beta3+3-dev

sgdev’s picture

sgdev commented

@cmseasy, if it's not applying, create a new version.

sano’s picture

sano commented
StatusFileSize
new commerce_checkout_login-remove_new_account_info-2682239-9.patch2.83 KB

A re-rolled patch for 7.x-2.0-beta3+3-dev is attached.