Commerce cart estimate is causing orphaned shipments (duplicate shipments in the admin)

This patch can't work as commerce_shipping is complaining about a missing order_id when proposed shipment value objects are being created... So this would require additional work in commerce_shipping.

This is causing shipments to be duplicated (See #3250006: Multiple Duplicate Shipments).

+++ b/src/LateOrderProcessor.php
@@ -0,0 +1,44 @@
+   *   The shipping order manager.
...
+    $this->inner = $inner;

Do we really need to set the inner class here since we are not using it?

Also, I'm still in favor of defining a custom order refresh service as discussed, instead of decorating the existing one, so we can just invoke it ourselves and don't have to worry about running it for regular orders or not?

Another note, you can also just swap the late order processor and extend the base order processor, via a service provider, just overridding the shouldSave() method.

Made several changes, also shortened the exception class names (no need to prefix by CartEstimate since we have namespaces).

Went with a custom order refresh as mentioned in #9, added a composer.json to require commerce_shipping dev so we can test this.

Also, we need to expand the EstimatorTest to assert that the order is not modified/saved etc etc.

Aborted the test as it seems that it was stuck in some kind of infinite loop.

Once we expand a bit the EstimatorTest, we could tag a new commerce_shipping release, require this new shipping version, and commit this.

@TomTech: thoughts?

These are all "blind" changes TBH. Wondering if we should skip refreshing prices though?

Experiencing the following locally:

Before the estimate:

After:

The subtotal changed, perhaps we need to refresh prices, not really sure what's missing, would need to dig a bit.

Realized we need to refresh prices, simply because a promotion reducing the unit price can be applied, which is what was causing the issue from the screenshot.

Expanded the tests to ensure the original order is not altered (checking the version and the total price to ensure they remain unaltered).

Not really sure whether we need custom exceptions or whether we should reuse the CartEstimateException that already exists although it has a different "meaning".

Other than that, I think we're good, I should probably tag a new commerce_shipping release and then update this patch.

Require Commerce shipping 2.4 minimum.

To avoid the BC with the new OrderRefreshInterface, decided to extend the order refresh service coming from commerce_order.

Actually seems more right to not extend the base class and simply implement the interfac, this way we don't depend on the services neeeded by the parent.

Committed! @TomTech: Thanks a lot!