In #1831778: Character limit set at 255, a commit was made which added support for patterns longer than 255 characters. However, it did not change the schema definition in hook_schema(), so new installs of this module will have the wrong schema.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelstein created an issue. See original summary.

joelstein’s picture

Status: Active » Needs review
FileSize
461 bytes

Here's a patch which updates the schema definition to match the 7103 update.

joelstein’s picture

Ok, also in #1189654: Max length of #edit-product-type-autosku-pattern field there was a commit made which undid the earlier commit by adding back the max length of 255 to the pattern field.

Here's an updated patch which also removes the maxlength. The pattern should be allowed to exceed 255 characters, even though the generated SKU must be within 255 characters (which the module already enforces).

joelstein’s picture

Oops, forgot the patch.

joelstein’s picture

Oops, simply unsetting the maxlength property won't do. We have to set it to NULL (otherwise it is implied to 128).