Replace server side credit card type detection with a js based

Dropping this here...I'm only just now testing this out but I am getting this error. My response has the card type at index 52, not 51

I came across the same issue as @chrisrockwell. It was inconsistent. I didn't get the error every time, but sometimes the card type is definitely in index 52. Attached is a workaround patch. It's not a good solution at all, but it prevents the form error and lets you complete checkout successfully.

So here is our real problem. Here's an example response string

1,1,1,This transaction has been approved.,000000,Y,2000000000,none,Test transaction for 
ValidateCustomerPaymentProfile.,0.00,CC,auth_only,none,John,Doe,,123 Main St.,Bellevue,WA,98004,USA,000-000-0000,,email@example.com,,,,,,,,,0.00,0.00,0.00,FALSE,none,E42C2F81807AA1B581DEA12EB6727604,P,2,,,,,,,,,,,XXXX1111,Visa,,,,,,,,,,,,,,,,,

We explode that string by commas. If any of the data has a , value it will throw off our keys. This could be due to a name or street address with a comma in it. Or name. That would explain why it is bumped up by one key.

I just realized the 7.x module has

  // Make the response an array and trim off the encapsulating characters.
  $response = explode('|', $result);

  for ($i = 0; $i < count($response); $i++) {
    $response[$i] = substr($response[$i], 1, strlen($response[$i]) - 2);
  }

which creates the array structure I assumed and copied.

Our code makes the right key assumption. #3 is a quickfix for when a value has a comma and skews the results.

Hrm. Per https://github.com/AuthorizeNet/sdk-php/blob/master/lib/AuthorizeNetAIM....

It does the same thing $this->_response_array = explode($delimiter, $response);

Then there is:

            $this->account_number       = $this->_response_array[50];
            $this->card_type            = $this->_response_array[51];
            $this->split_tender_id      = $this->_response_array[52];

We need sanitized validationDirectResponse and validationDirectResponseList responses to test this.

The server side detection is going to be fixed in #2968123: Validation direct response can be broken by delimiter in customer data

Needs a re-roll.