The latest version enable authenticated user see everyone's addressbook just by change the number in the url contextual argument.

I'm not sure it's something wrong with my permission or it's a bug.

CommentFileSizeAuthor
#2 commerce_addressbook-fix-addressbook-permission-1996654-2.patch1.4 KBjsacksick
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented
Assigned: Unassigned » jsacksick
Priority: Normal » Major

You're right, this bug has been introduced by the patch coming from this issue #1961854: Address Book tab not displaying for authenticated users.

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented
Status: Active » Needs review
FileSize
commerce_addressbook-fix-addressbook-permission-1996654-2.patch1.4 KB

Can you try with that patch ?

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented
Status: Needs review » Fixed

I decided to go ahead and I merged it.

relaxpor’s picture

relaxpor CreditAttribution: relaxpor commented

Sorry guy, the last patch give me fatal error.

Something wrong with this show in the log.
[17-May-2013 22:51:30 Asia/Bangkok] PHP Fatal error: Call to undefined function  user_access() in /Applications/MAMP/htdocs/himaparn/sites/all/modules/contrib/commerce_addressbook/commerce_addressbook.module on line 173
[17-May-2013 22:51:30 Asia/Bangkok] PHP Stack trace:

caktux’s picture

caktux CreditAttribution: caktux commented
Version: 7.x-2.0-rc5 » 7.x-2.x-dev

Confirmed #4

caktux’s picture

caktux CreditAttribution: caktux commented
Status: Fixed » Needs work
yaslama’s picture

yaslama CreditAttribution: yaslama commented

It seems that the problem of #4 is caused by bad characters in lines 173 and 174 of commerce_addressbook.module.
One can see them clearly in the diff: http://drupalcode.org/project/commerce_addressbook.git/blobdiff/8b058a84...

relaxpor’s picture

relaxpor CreditAttribution: relaxpor commented
Status: Needs work » Closed (fixed)

after delete this character, it's fixed!

agileadam’s picture

agileadam
Location Maine, USA
CreditAttribution: agileadam commented

I can confirm the bug in #7. Removing these characters fixes the "Call to undefined function user_access()" issue.

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented

A new version has been tagged without the characters already, you should use that one.