In reference to http://drupal.org/node/1243846 , shipping information fieldset does not go away when addressbook enabled.

The field 'select saved address' still shows.

CommentFileSizeAuthor
#13 commerce_addressbook-hide-select-when-using-same-address-1427264-13.patch1 KBB-Prod
#12 commerce_addressbook-hide-select-when-using-same-address-1427264-12.patch934 bytesB-Prod
#8 hide-select-box-1427264-8.patch737 bytesDuaelFr
Screenshot shipping.png24.75 KBfarald
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ibuildit’s picture

ibuildit CreditAttribution: ibuildit commented

confirmed, i have the same problem

farald’s picture

farald CreditAttribution: farald commented

Would be nice of them to cooperate, checkbox is great for first-time customers, select list is cool for logged-ins.

Could remove the "same address as shipping" checkbox using hook_form_alter when select lists are present, but again, cool if they could coexist.

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Active » Fixed

Works for me with the 7.x-2.x branches of Shipping and Addressbook.

IckZ’s picture

IckZ CreditAttribution: IckZ commented

i've the same problem instead of using the dev versions of both modules..

I also think that this would be the better way: http://drupal.org/node/1243846#comment-5340398

Anyone who has tested this with addressbook?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jazzdrive3’s picture

jazzdrive3 CreditAttribution: jazzdrive3 commented
Status: Closed (fixed) » Active

I am using both of the latest dev versions, and the select box for shipping addresses is still showing when you select "Use billing address as shipping address"

drewmacphee’s picture

drewmacphee CreditAttribution: drewmacphee commented

Same here

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
Status: Active » Needs review
FileSize
hide-select-box-1427264-8.patch737 bytes

I do not really enjoy this solution but there is a patch which hides the select box when the "Use billing address as shipping address" is checked.
I think this is a quick and dirty solution but I am not able yet to do better.

bojanz’s picture

bojanz CreditAttribution: bojanz commented

Thanks for the patch.

The "Use billing address as shipping address" functionality is being rewritten in the Commerce issue: #1410022: Improve copy address functionality - create a more generic solution.
I won't be investigating addressbook compatibility until that patch lands.

brephraim’s picture

brephraim CreditAttribution: brephraim commented

Addendum to this issue: every time a customer places an order using the select box for shipping information, a duplicate shipping address is created in the customer's addressbook.

brephraim’s picture

brephraim CreditAttribution: brephraim commented
Status: Needs review » Active
B-Prod’s picture

B-Prod CreditAttribution: B-Prod commented
Category: bug » feature
Status: Active » Needs review
FileSize
commerce_addressbook-hide-select-when-using-same-address-1427264-12.patch934 bytes

Here is a new patch since the related issue has been ported in Commerce module (DEV version - commerce.git-8d5c51f).

The patch modifies the weight of the address book select element to take care of the "same address" checkbox weight, which is 30. This do not have any side effects as far as I know.

B-Prod’s picture

B-Prod CreditAttribution: B-Prod commented
FileSize
commerce_addressbook-hide-select-when-using-same-address-1427264-13.patch1 KB

As discussed in the following issue #1794064: Update after Commerce 1.4 to work alongside customer profile copying, the address book select element should not be hide but totally removed, otherwise it updates existing profile instead of creating a new one.

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented
Status: Needs review » Closed (won't fix)

In #1794064: Update after Commerce 1.4 to work alongside customer profile copying we decided to keep the checkbox and the select list but now when you select an address the checkbox is unchecked.
When you check the profile copy checkbox then the address selected is unselected.