Recently, the modules/checkout/js/commerce_checkout.admin.js was refactored to use arrow functions. This change has broken the dragging functionality of checkout flows.
In fact, a console error is shown, just by visiting the admin/commerce/config/checkout-flows/manage page for a flow.
Consequently, the position of dragged items are not saved when clicking on the save button.
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | 3414853-17.patch | 783 bytes | jsacksick |
| #5 | 3414853-5.patch | 3.36 KB | tbkot |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
larjohn commentedComment #5
tbkot commentedPatch based on changes in MR
Comment #6
tbkot commentedComment #7
anybodyConfirming this issue, just ran into it. No changes are being saved anymore.
Comment #8
anybodyHaven't looked deeper into the code, but the patch fixes the issue! Thank you @tBKoT! :)
Comment #9
proweb.ua commented#5 works
Comment #12
jsacksick commentedCommitted, thank you for this!
Comment #13
anybody@jsacksick I think I had issues yesterday with empty regions. The dragged elements landed somewhere else after saving. I guess this needs tests to compare the hidden select value set to the region name?
And for the quickfix I think it needs some more manual testing of such edge cases. Didn't have the time so far to do it, just wanted to let you know that there *might* still be issues with this.
Only tests can safe us ;)
Comment #14
jsacksick commentedI don't see any actual functionality change in the PR... Just "fixing" the existing code (unless I'm missing it), so it might be that the issue was present before?
Comment #15
anybody@jsacksick that's possible. I'll try to reproduce it, just wanted to let you know. I dragged and dropped around a lot in the checkout flow yesterday and everything seemed to work fine except dragging into a region that was empty before. After saving, the item went into a differnet region, but I had no time to check it in detail and so I then made the changes using the "Show weights" functionality without Js through the selects.
Just wanted to let you know about the potential bug.
Without the fix from here, the whole d&d was broken as described.
Comment #16
jsacksick commentedYou're right... Reopening this as dragging to an empty region is broken....
Comment #17
jsacksick commentedComment #22
jsacksick commentedComment #23
anybodyThank you very much @jsacksick! 🎉
Comment #24
hockey2112 commentedAre both patches necessary to resolve this issue?
Comment #25
anybody@hockey2112 no it's fixed in the latest dev release!
Perhaps we can have a new stable?
Comment #26
liliplanet commentedYes please, new release as it affects order checkout flows considerably, thank you.
Comment #27
jsacksick commentedNew release was tagged today!
Comment #28
liliplanet commentedHi @jacksick, updated to latest version, still no joy, drag is not saving.
Comment #29
jsacksick commentedHI @Liliplanet, did you rebuild your caches? It works perfectly for me and the fix was confirmed by 2 other people at least in this issue?
Comment #30
liliplanet commentedHi @jacksick, yes thank you. Yes I updated via composer (with all dependencies), rebuilt cache, still not saving.
Comment #31
liliplanet commentedHi @jacksick, awesome news. I just upgrade D10 and it fixed, drag and drop saves beautifully, thank you!