Table on the page with product variations contains untranslatable machine name of product variation type.
Enable module commerce_product. Add a product and a product variation. Open page with list of product variations (/product/{product_id}/variations)
It would be better to display label of product variation type instead of their machine name because the label is translatable and the label can be clearer for users who do not configure site but manage products on the site.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3335429-5.patch | 3.69 KB | jsacksick |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
sergei_brill commentedComment #4
jsacksick commented@sergei_brill: Kinda tricky to modify the constructor arguments like this, but well, that should only be a problem for people extending the list builder.
Instead of having a
$productVariationTypeStorage, let's just inject/use the entity type manager in case we need to get a different storage later too.Comment #5
jsacksick commentedComment #6
jsacksick commentedCommitted, thank you!
Comment #10
sergei_brill commented@jsacksick Good note about the backward compatibility. But you made release with this issue so fast so, I couldn't fix it in time :)
Just in case you want to keep \Drupal\commerce_product\ProductVariationListBuilder compatible with previous versions of commerce 2, there is one more MR.
PS Commit it to 8.x-2.x only, 3.0.x may have BC breaks, I think.