Problem/Motivation

The configurable field manager service assumes that the bundle key for an entity will be called type.

Proposed resolution

Get the entity bundle key from the entity definition instead.

CommentFileSizeAuthor
#3 cfm-bundle-key-3177163-3.patch816 bytesericchew

Issue fork commerce-3177163

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ericchew created an issue. See original summary.

ericchew opened merge request !11

ericchew’s picture

ericchew commented
StatusFileSize
new cfm-bundle-key-3177163-3.patch816 bytes

Uploading merge request in patch format.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Assigned: ericchew » jsacksick
Status: Active » Needs review

Looks good to me, pinging @jsacksick for a second opinion.

jsacksick’s picture

jsacksick commented
Status: Needs review » Reviewed & tested by the community

Looks good to me as well.

  • mglaman committed d85d85a on 8.x-2.x authored by ericchew 
    Issue #3177163 by ericchew, mglaman, jsacksick: ConfigurableFieldManager...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Assigned: jsacksick » Unassigned
Status: Reviewed & tested by the community » Fixed

🥳 Thanks @ericchew for the find, thanks @jsacksick for the 2nd opinion. MERGED!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.