Problem/Motivation

AdjustmentDefaultWidget displays each of its form elements on their own "row", leaving a lot of empty space beside them.

Proposed resolution

Display some of the fields inline.

Remaining tasks

Review.

User interface changes

Before:

After:

API changes

Nope.

Data model changes

Nope.

CommentFileSizeAuthor
#4 3164368-4.inline_adjustment_widget.patch1.36 KBrszrama
#2 3164368.patch1.05 KBamateescu
adjustments-after.png23.95 KBamateescu
adjustments-before.png26.67 KBamateescu

Comments

amateescu created an issue. See original summary.

amateescu’s picture

amateescu commented
StatusFileSize
new 3164368.patch1.05 KB

This should do it. I think the Included in the base price field is important enough to be displayed on its own.

amateescu’s picture

amateescu commented
Status: Active » Needs review
rszrama’s picture

rszrama commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3164368-4.inline_adjustment_widget.patch1.36 KB

Nice change - this bothered me on the order edit form but I was unaware we had these classes in D8. I've made a slight adjustment here to reduce the size of the label textfield, as leaving it at the default of 60 meant the price was still on the next line with the order edit form sidebar present (on my 1440 px width laptop screen at least). This should be plenty wide enough for most adjustment labels, and the maxlength remains unchanged.

  • mglaman committed 2187749 on 8.x-2.x authored by amateescu 
    Issue #3164368 by amateescu, rszrama: Minimize the wasted vertical space...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Reviewed & tested by the community » Fixed

🥳 Yay, makin' things pretty. Committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.