commerce_order_item_table needs to filter out orphan order items

added #3069966: Orphans in commerce_order_item table as a related issue

@skyredwang - I ran into this issue today. Order came through and the commerce_order_item_table had 30+ items in the table, then the edit screen only had the one item actually ordered.

I might be able to provide some context of how it came about, too, in case that helps figure out the issue. Adding that patch to the view didn't solve my issue.

I was doing some random testing on adding items to carts as anonymous users very quickly. At one point there were 3 or 4 anonymous carts open. Then, I went in and just manually deleted the carts through /admin/commerce/orders/carts by bulk deleting them when I was finished testing a few things. I haven't confirmed this was the actual cause of the issue but what is showing up in the commerce_order_item_table looks suspiciously like the items I was randomly adding to carts and the order that was displaying weird in commerce_order_item_table was the very next order processed.

Hopefully helps to get to the bottom of this. Cannot figure out how to fix the table for my client.

Thanks!

I adapted my view with the relationships of the patch in #2, but that didn't get rid of the orphan items for me. It rather added two duplicates of every existing line item.

I found a temporary workaround that fixes the issue for me:

<?php
/*
 * Implements hook_views_pre_render().
 */
function MODULE_views_pre_render(ViewExecutable $view) {
  if ($view->id() === 'commerce_order_item_table') {
    foreach ($view->result as $key => $item) {
      /** @var \Drupal\commerce_order\Entity\OrderItem $order_item */
      $order_item = $item->_entity;
      $order = $order_item->getOrder();
      if (!$order->hasItem($order_item)) {
        unset($view->result[$key]);
      }
    }
  }
}
?>

I think the proper/easiest fix for this would be to update the orders item table view, add an order item ID contextual filter, and pass the order item IDS referenced by the order, instead of an order ID contextual filter.

That prevents the need of adding 2 relationships which causes duplicate results.

The only problem with changing that is that it requires the order item table view to be reverted, and that can potentially mess up people's customizations.

This should hopefully fix the tests.

I deployed this on a project and for some reason, the view didn't get reverted...

the revert() command skips modified configuration by default - so if your project had a modified commerce_order_item_table view, it won't get changed

A change record was created. See https://www.drupal.org/node/3197301.

Thanks for the great work...however I am reopening this bug because the committed fix has broken existing Drupal Commerce installations (critically might I add).

After upgrading to the 8.x-2.24, when a user increases the quantity in their shopping cart and then proceeds to the payment page, then the "Order Summary" view displays an inaccurate quantity amount.

I tested this same scenario on Drupal Commerce 8.x-2.21 and it works as expected.

Took me a few hours to track this down.

A quick solution to get it working on Drupal Commerce 8.x-2.24 is to revert the view to use the contextual filter of "Order item: Order" (and not checking "Allow multiple values").

Also there are at least 2 other people in the comments of the change record who are having similar problems. (although I am not sure if all the issues are related).

@xamount: What you're describing seems to be a different bug to me...

This isn't touching the order summary view.

Also there are at least 2 other people in the comments of the change record who are having similar problems. (although I am not sure if all the issues are related).

People reported that the view didn't get reverted, and the change records contains instructions for manually updating the contextual filter.

The change introduced in this issue only affects the order items table view.

If you're having a different bug, please open a new issue with clear steps explaining how to reproduce the issue.

As commented at #27, order items view has not "Order item: ID" contextual filter by default, but "Order item: order", so your instructions are not accurate. And users, like @xamount or myself could be confused.

I guess in lastest clean installs the contextual filter is "Order item: ID" but I suppose it has changed in some point in the past... Just guessing...

I wonder what "Order item: order" instances should do... Please, re-open this ticket until this important question get solved :-)