People often extend the PaymentInformation pane to customize it. Most just disable the original pane and give the new one a new ID, but that disables the PaymentProcess pane. The PaymentProcess pane hardcodes the payment_information pane ID in 3 places, and if only one is replaced by accident, really odd bugs can happen (sending a user to checkout/:step_id/_disabled for example).
Plan of action:
1) Add a comment to the PaymentInformation docbock to tell people the proper way of replacing the pane (removing the need to override PaymentProcess).
2) Reduce the number of protected methods in PaymentProcess, reduce the number of places payment_information is hardcoded in, to simplify overriding PaymentProcess even if its not needed.
3) Validate the $step_id in CheckoutFlowBase::redirectToStep(), to protect against "_disabled",
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3005796-3.patch | 6.84 KB | bojanz |
Comments
Comment #2
bojanz commentedComment #3
bojanz commentedPatch.
Comment #5
bojanz commentedAnd done.
Comment #6
bojanz commentedComment #8
bojanz commentedAdded an additional exception. This one would be triggered each time the PaymentProcess pane is rendered, and not just when the payment method is declined, making it easier to catch & debug.