Scenario: We are getting to a point where Taxes are often applied even when the store does not reside in that Tax Zone.
This patch will allow this to be configurable per Tax Type.

screenshot

By default, this is checked.
If you uncheck, the Tax Type will not check the store address.

CommentFileSizeAuthor
#13 commerce-match_store_to_tax_zone-3005440-13.patch3.97 KBthenchev
#10 interdiff-2_10.txt2.54 KBjonnyeom
#10 commerce-match_store_to_tax_zone-3005440-10.patch4.08 KBjonnyeom
#2 commerce-match_store_to_tax_zone-3005440-2.patch3.52 KBjonnyeom
Selection_076.png10.02 KBjonnyeom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jonnyeom created an issue. See original summary.

jonnyeom’s picture

jonnyeom CreditAttribution: jonnyeom as a volunteer commented
FileSize
commerce-match_store_to_tax_zone-3005440-2.patch3.52 KB
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

You will need to make a strong case for why such an option should be accepted and available.

At this point in the release cycle I try to delegate every such custom use case to custom code.

Status: Needs review » Needs work

The last submitted patch, 2: commerce-match_store_to_tax_zone-3005440-2.patch, failed testing. View results

jonnyeom’s picture

jonnyeom CreditAttribution: jonnyeom as a volunteer commented

So, earlier this year, the Supreme Court passed a ruling that States can charge taxes despite not having a physical presence in a state.
Here is an article.

I found that I currently have a use case directly related to this so I made a patch. Your thoughts?

Maybe there is a better approach for handling this. Still thinking.

vood002’s picture

vood002 CreditAttribution: vood002 commented

I also have a use case for this functionality.

I have a client who has to charge sales taxes in two states as their business is based in one, but the company that handles their fulfillment is based in another.

I installed this patch on 2.11 and it solved the problem for me. I have to imagine this is not that rare of a situation.

rwhirn’s picture

rwhirn CreditAttribution: rwhirn commented

I believe it should say exactly what the message now says, should just be a checkbox to turn off:
o tax type will be used only if both the customer and the store belong to one of the territories

or radio buttons:
o tax type will be used only if both the customer and the store belong to one of the territories
o tax type will be used if the customer belongs to one of the territories

themic8’s picture

themic8 CreditAttribution: themic8 commented

jonnyeom, Thank you, this fixed the same issues I was working through.

Current project: I needed to be able to apply tax based on the state, not just the state the store is based out of. I also needed to be able to apply VAT tax for countries in Europe.

Currently using Drupal commerce 8.x-2.11

BrightBold’s picture

BrightBold
she/her
Primary language English
Location Boston, MA
CreditAttribution: BrightBold commented

Use case for this feature: US store with a small number of nexuses so they didn't think it warranted a tax cloud. In D7, Rules allowed them to have per-state tax rates triggered by the customer's location only. Upon upgrading to D8, this is no longer an option. Having this checkbox would allow upgrading sites to retain the same functionality they had in Commerce 1.x; it feels like a regression to have lost it.

jonnyeom’s picture

jonnyeom CreditAttribution: jonnyeom as a volunteer commented
Status: Needs work » Needs review
FileSize
commerce-match_store_to_tax_zone-3005440-10.patch4.08 KB
interdiff-2_10.txt2.54 KB

Updating the patch with updated tests.

Glad there are various use cases for this!

noah’s picture

noah CreditAttribution: noah as a volunteer commented

A Canadian business we're working with has grandfathered in some odd (but legal) tax rules that don't match the built-in "Canadian sales tax" plugin, but require that different taxes be charged to customers in different provinces regardless of the location of the store. This patch applied successfully to 2.16 (with some offsets) and is accomplishing what we need—thanks!

(I'm never sure when something should become RTBC, so I'm not going to change this, but it looks good to me.)

arunkumark’s picture

arunkumark
Location Coimbatore
CreditAttribution: arunkumark commented

Applied patch #10. Working as expected.

thenchev’s picture

thenchev CreditAttribution: thenchev at Acro Commerce commented
FileSize
commerce-match_store_to_tax_zone-3005440-13.patch3.97 KB

reroll

Status: Needs review » Needs work

The last submitted patch, 13: commerce-match_store_to_tax_zone-3005440-13.patch, failed testing. View results

jsacksick’s picture

jsacksick CreditAttribution: jsacksick at Centarro commented
Status: Needs work » Closed (won't fix)

The "tax registration" setting needs to be used now. There's no longer a matching done on the store address, this has changed in the latest 2.28 release.

See #3246388: Local tax type application should be determined based on the tax registrations.

noah’s picture

noah CreditAttribution: noah as a volunteer commented

Is there any documentation on how to achieve this functionality using the "tax registration" system? The store we're managing is in Canada, but its tax rules don't match the out-of-the-box Canadian sales tax rules—are we looking at having to write a custom tax plugin, or should we be looking for a different path forward? All we need to do is ignore the store address when determining the tax rate.

Any advice appreciated.