ProductForm is trying to attach an non existent library [#2946659]

ProductForm is trying to attach the non existent library "commerce_product/drupal.commerce_product" to $form['author']. This fails silently, without any warning on screen or in watchdog. So it's nothing more than an unimportant blemish

Comment	File	Size	Author
#2	stop_attaching_non_existent_library-2946659-2.patch	530 bytes	agoradesign
#2	8.x-2.x: PHP 5.5 & MySQL 5.5, D8.4 447 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

21 February 2018 at 20:33

agoradesign created an issue. See original summary.

Comment #2

agoradesign CreditAttribution: agoradesign commented 21 February 2018 at 20:33

Status:

Active

» Needs review

File	Size
stop_attaching_non_existent_library-2946659-2.patch	530 bytes
8.x-2.x: PHP 5.5 & MySQL 5.5, D8.4 447 pass

Comment #3

22 February 2018 at 12:40

bojanz committed 5be779d on 8.x-2.x authored by agoradesign

Issue #2946659 by agoradesign: ProductForm is trying to attach an non...

Comment #4

bojanz CreditAttribution: bojanz at Centarro commented 22 February 2018 at 12:46

Status:

Needs review

» Fixed

Thanks! This is a leftover from when we copied the sidebar from core, I think.

Comment #5

agoradesign CreditAttribution: agoradesign commented 22 February 2018 at 15:54

seems so... it present since the first commit of the file (which was at time of renaming it from CommerceProductForm... I stumbled across it, when I was myself copying stuff over from ProductForm class to my ProductSetForm class :D