When multiple order item types and multiple order types are created, the "Inline entity form - Complex" widget allows order items of any types to be added to orders. There is a select menu to the left of the the "Add new order item" button that offers the choice of any order item type. This is incorrect behavior. Only order item types corresponding to the order type should be allowed to be added to an order. There's a UI bug where the order item type is being ignored by the widget (and possibly by the underlying field).
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | commerce-2890837-order_item_type_validation-10.patch | 1.35 KB | loze |
| #9 | commerce-2890837-order_item_type_validation-9.patch | 1.51 KB | tkiehne |
| #7 | commerce-2890837-order_item_type_validation-7.patch | 1.54 KB | czigor |
Comments
Comment #2
jackbravo commentedThis issue was created in response to this drupalStackexchange question: https://drupal.stackexchange.com/questions/237694/commerce-2-x-confusion...
Comment #3
czigor commentedAdded a check in OrderForm.
Comment #4
czigor commentedAdding an isset() check to prevent notices in case the form is not using IEF or does not allow adding new line items.
Comment #7
czigor commentedAdding one more variable check.
Comment #8
czigor commentedComment #9
tkiehne commentedRe-rolling this against the latest 2.x branch.
Comment #10
loze commentedWas no longer applying, Rerolled for the latest dev
Comment #12
jsacksick commentedCommitted, thanks!
Comment #15
ankondrat4 commentedA little bit confusing update and request. Why we need to forbid adding different types of order items to the order?