Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RoSk0’s picture

Status: Active » Needs review
FileSize
4.88 KB

Patch.

joelpittet’s picture

+++ b/modules/order/includes/views/handlers/commerce_order_handler_area_order_total.inc
@@ -11,6 +12,23 @@ class commerce_order_handler_area_order_total extends views_handler_area {
     // TODO: Update with option definitions if the display formatter itself

This kinda looks like it resolves this @todo no?

This patch looks great, I don't currently have need for this but I'm sure someone does!

RoSk0’s picture

About TODO: it looks so, but I wasn't sure and decided to leave it as is. Should I get rid of it?

joelpittet’s picture

If we can find the person who wrote it that would be best, but I'd say maybe remove it and if someone says anything it can be added back.

RoSk0’s picture

@rszrama added this in 983181f9dae9f1cdedcb960a10eaf964ac6ebc42.
New patch version without TODO comment.

torgosPizza’s picture

Status: Needs review » Reviewed & tested by the community

This does exactly what we need, so thanks! Basically we have the coupon form on the Cart page from #2872455: Allow coupons to be redeemed on the cart page, but when adding a coupon, the order total currently shown does not reflect the discount. This also happens with Gift cards and other site-wide discounts: the Order Total handler for Views seems to not calculate prices by default, which seems like an odd choice, but in any case this patch allows us to show users more information about their current cart, and avoids confusion when the current price is not reflected there.

rszrama’s picture

I've updated the patch to make code, comment, and interface changes. I changed the help text when enabling a custom label to make it clear that theme updates may be required since adding a label breaks some default CSS. Otherwise, looks good to go!

  • rszrama committed 41cd990 on 7.x-1.x authored by RoSk0
    Issue #2454683 by RoSk0, rszrama: Allow to change order total display...
rszrama’s picture

Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.