Unable to uninstall due to PHP fatals because hook_menu() is called by core when uninstalling [#1017006]

Comment #1

PieterDC

Dutch

Ghent

CreditAttribution: PieterDC commented 6 January 2011 at 18:17

I can confirm those errors.

Log in or register to post comments

Comment #2

rszrama CreditAttribution: rszrama commented 7 January 2011 at 22:28

Status:

Active

» Postponed (maintainer needs more info)

This isn't enough to know what's going on... are you trying to uninstall the Product module before uninstalling the Product UI module? We already know uninstallation is broken, but I can uninstall Customer UI without generating any errors (for example). I don't even have the option to uninstall Customer prior to Customer UI, and it's the API modules that define those functions you're missing.

Log in or register to post comments

Comment #3

aidanlis CreditAttribution: aidanlis commented 7 January 2011 at 23:46

This is easily replicated - fresh install, install all commerce packages, uninstall commerce packages one by one until all you have left is greyed out packages and the three UI packages. These packages can then no longer be removed due to the above errors.

Log in or register to post comments

Comment #4

rszrama CreditAttribution: rszrama commented 8 January 2011 at 00:25

What do you mean one by one? Can you provide a list of modules in order that you're uninstalling? I can't uninstall Product before Product UI, for example, and thus the undefined function would never be missing.

Log in or register to post comments

Comment #5

aidanlis CreditAttribution: aidanlis commented 8 February 2011 at 00:16

Status:

Postponed (maintainer needs more info)

» Active

It sounds like you're assuming that product would be loaded in memory when product_ui is being uninstalled, this isn't the case. Imagine this sequence:

drush pm-disable commerce
drush pm-uninstall commerce_product_ui

This can be done with drush or through the UI, it still happens. Installing commerce_product allows drush pm-uninstall commerce_product_ui to work.

I've confirmed this bug for the latest code in github.

Log in or register to post comments

Comment #6

gorillaz.f CreditAttribution: gorillaz.f commented 10 February 2011 at 07:53

I got a white screen when I tried to uninstall any XX UI sub-module of commerce ( product UI etc)
I'm using alpha5 of commerce and 7.0 core

Log in or register to post comments

Comment #7

rszrama CreditAttribution: rszrama commented 14 February 2011 at 04:50

Status:

Active

» Postponed (maintainer needs more info)

I still don't understand this issue. I hardly thing it's our job to support users breaking the uninstall order using drush... if the UI prevents a module from being uninstalled (i.e. Product before Product UI), that's good enough for me. If this is purely a drush user issue, I'm happy to close it and trust them not to screw things up on their own sites.

There's also a related (though not exactly duplicate) issue here that is more important: #858722: Cannot reinstall Commerce modules after uninstall due to field deletion failure

Log in or register to post comments

Comment #8

aidanlis CreditAttribution: aidanlis commented 14 February 2011 at 18:38

Status:

Postponed (maintainer needs more info)

» Active

- drush does respect the uninstall order
- I'm only uninstalling a single module here so the uninstall order is not relevant

Log in or register to post comments

Comment #9

rszrama CreditAttribution: rszrama commented 14 February 2011 at 18:47

Ok, it's been confirmed in the other uninstall issue and it appears it might be a core bug. Refer to comment #24 in #858722: Cannot reinstall Commerce modules after uninstall due to field deletion failure. Not sure what we should do about it.

Log in or register to post comments

Comment #10

aidanlis CreditAttribution: aidanlis commented 14 February 2011 at 23:53

Re: #603798: When a module is being uninstalled, it's hook_menu() is called, agree it's something that should be resolved in core, however having module dependent code in hook_menu is relatively rare. For the meantime, perhaps in hook_menu (or anywhere that code is run unconditionally) we should do a drupal_load('module') ... there's little to no overhead.

Glad we got there after 3 postponed's :)

Log in or register to post comments

Comment #11

aidanlis CreditAttribution: aidanlis commented 14 February 2011 at 23:56

Found a more in-depth discussion of 603798 at #1029606: Regression: Not loading the .module file causes a fatal error when uninstalling some modules (as does loading it)

Log in or register to post comments

Comment #12

rszrama CreditAttribution: rszrama commented 15 February 2011 at 14:24

Does that patch fix the issue for you by any chance? A review on that issue would be great.

Log in or register to post comments

Comment #13

aidanlis CreditAttribution: aidanlis commented 15 February 2011 at 16:41

The patch indeed fixes the issue as hook_menu is not called. I guess we'll just have to wait for that patch to be committed before we close this issue.