Site builders have in core a Skip comment approval permission, so I'm taking out the Skip comment approval by node author permission.

If I've missed an important use-case or this is a feature you just -loved- having it in usercomment, let me know here.

Committing to dev.

CommentFileSizeAuthor
redundantperm.patch1.06 KBrschwab
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ruess’s picture

Status: Closed (fixed) » Active

Am I to understand that there was once a feature that allowed you to allow certain roles to "skip approval for comments" for specific content types?

If so, they yes, I feel this should be added back in. In my use case, I am working on a reviews site/directory. One of my content types is the actual business being reviewed and so with that, I would like reviews (aka comments) to be held up before they are approved. However, I would rather let all the rest of my content types, like discussion boards, be free and not stop comments from being posted. Thus, I can see a good use case for such granularity.

Thoughts?

Thanks,

ruess

rschwab’s picture

Title: Skip approval permission is redundant. » Add granularity to "skip approval" permission
Category: task » feature

Hi ruess!

Thanks for using the module!

The permission removed in this patch did the same thing the comment module permission does - it basically made the comment module permission do nothing.

Right now the code gives the comment module permission the final say: If "skip comment approvals" is checked, it skips admin moderation and the user approval in Comment Access. If "skip comment approvals" is not checked then it relies on Comment Access to determine if user approval is needed.

It would be possible to change that, and give the Comment Access permissions the final say over comment module. Then, to set your site up the way you described:
- Allow authenticated users (or any role you want) to skip comment approvals using the core comment module permission.
- Give business owners (or whoever owns the nodes being reviewed) the ability to approve comments on review node types, using the comment access modules.

I'll think this over for a bit because it could really change the way people have used the module to build their sites. Anyone who wants to provide feedback on this, please do!

rschwab’s picture

Title: Add granularity to "skip approval" permission » Allow users to skip comment approval by content type.

Changing the way the module works on everyone who has it installed and working (as I described in #3) seems like a really bad idea.

I'm changing the title of this to reflect a different way of doing this: Adding a checkbox to the form in Edit Content Type to allow comments to be posted without any approval, per content type.

  • rschwab committed 4bc159d on 7.x-1.x
    #1044304 Removing redundant permission.