Problem/Motivation

In the node-centric design of 7.x-*, comment notification subscribability is defined per node type. It should rather be defined wherever there's comments, i.e. per comment field.

Proposed resolution

Switch from the comment_notify.settings:node_types setting to third_party_settings on comment fields.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Arla created an issue. See original summary.

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented
Status: Active » Closed (won't fix)

We fixed this as part of #2618182: Support all entity types as commentable, not only nodes now it is saved per field... the only thing is that this saved in the comment_notify.settings config not in the third party settings.

And it is working and it is easy to access all the configurations from a single place instead to iterate all the fields to get the data...

So, I think we are good with our current model and I'm going to close this issue.

Thanks!