If you have a comment with multiple fields, you can reorder those fields from the comment fields tab (/admin/structure/types/manage/article/comment/fields). However, the Comment Notify Settings field added by this module does not respond to the order set by this page. It appears within the field ordering UI, and you can drag it around or set the row weights manually, but it is not guaranteed to display where you told it to on the actual comment forms.

CommentFileSizeAuthor
#4 Issue-2018349-by-archwaykitten-fixed-by-fiftyz-0.patch2.11 KBSilviuChingaru
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

archwaykitten’s picture

archwaykitten CreditAttribution: archwaykitten commented

There is a workaround to the above problem. The Comment Notify Settings field weight seems to be regarded as zero regardless of the weight listed by the UI. You may still be able get the field to appear where you need it to by manually adjusting all of the other field weights (by clicking the "show row weights" button) to be ordered around the Comment Notify Settings field weight, which is stuck at zero.

For example, if you want your Comment Notify Settings to appear at the bottom a group of fields, you need to manually set all of those fields' weights to be negative numbers so they come in before the Notify field.

dercheffe’s picture

dercheffe
he/him
Primary language German
Location Sersheim, Germany
CreditAttribution: dercheffe commented

Subscribe.
Edit:

Generally the workaround with the negative weight values works fine.

In my case, I have to use the comments form of my node as a form for a review. So the comment form contains different text fields, date fields, selection lists and fivestar-widgets for rating some criteria.

To serve the display of the form more suitable for my visitors, I'm using the multistep feature by the "field group" module (project page: https://drupal.org/project/field_group).

I can't put the comment notify field in one of my groups/steps, although I use the negative values for the weight.
I guess it's asssociated with this bug here, that comment notify crashes my layout. As long as this bug exists, I can't use this great module. Are there any solutions?

Thanks for any help.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
CreditAttribution: kscheirer commented

I think this is because comment_notify is using form_alter to add its elements, instead of providing a field. I could be wrong. Do we need to change that?

SilviuChingaru’s picture

SilviuChingaru CreditAttribution: SilviuChingaru commented
Issue summary: View changes
FileSize
Issue-2018349-by-archwaykitten-fixed-by-fiftyz-0.patch2.11 KB

The problem was from comment notify form component which drupal expects to be the same name as the extra field name. The sort of fields is done in _field_extra_fields_pre_render().

SilviuChingaru’s picture

SilviuChingaru CreditAttribution: SilviuChingaru commented
Status: Active » Needs review
kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
CreditAttribution: kscheirer commented

Looks like a good patch to me, I didn't actually test it though.

BWPanda’s picture

BWPanda CreditAttribution: BWPanda commented
Version: 7.x-1.2 » 7.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

Patch seems to work fine.

  • greggles committed 8dd104c on 7.x-1.x authored by fiftyz 
    Issue #2018349 by fiftyz: Comment Notify Settings field doesn't respond...
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at Morris Animal Foundation commented
Status: Reviewed & tested by the community » Fixed

Now fixed - thanks for your help, fiftyz!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.