We should convert the module to short array syntax as per new coding standard

CommentFileSizeAuthor
#3 comment_ip_array_search_results.png45.43 KBdhruveshdtripathi
#2 2876848-2.patch2.46 KBPavan B S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Assigned: Pavan B S » Unassigned
Status: Active » Needs review
FileSize
2876848-2.patch2.46 KB

Applying the patch, please review

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Status: Needs review » Reviewed & tested by the community
FileSize
comment_ip_array_search_results.png45.43 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier here were 5 array declarations, after applying patch there are 0.

Good work!

  • Pavan B S authored 719fa44 on 8.x-1.x 
    Issue #2876848 by Pavan B S: Convert module to use short array syntax (...
davidsonjames’s picture

davidsonjames CreditAttribution: davidsonjames at CTI Digital commented

Applied to 8.x-1.x, thanks all.

davidsonjames’s picture

davidsonjames CreditAttribution: davidsonjames at CTI Digital commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.