Strict warning: Only variables should be passed by reference [#2892182]

I can't get this module to work in display full display. I'm using display suite.

This is the error generated in my logs.

Strict warning: Only variables should be passed by reference in colorbox_field_formatter_field_formatter_settings_form() (line 73 of /home/mysite/public_html/sites/all/modules/colorbox_field_formatter/colorbox_field_formatter.module).

the link is well written with ?width=500&height=500 but my content opens in a new tab.
Colorbox field formatter

Thanks for any help.

Comment	File	Size	Author
	drupal.jpg	41.67 KB	morybel
#4	display2.PNG	13.16 KB	morybel
#4	display1.PNG	6.46 KB	morybel
#4	display0.PNG	2.54 KB	morybel

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

4 July 2017 at 17:32

morybel created an issue. See original summary.

Comment #2

jurgenhaas

he/him

German

Gottmadingen

CreditAttribution: jurgenhaas at LakeDrops, PARAGON Executive Services GmbH commented 5 July 2017 at 13:08

The two issues are not related. I have fixed the strict warning thing, which is simply a warning but doesn't change anything.

The fact that your link doesn't open in a popup is probably due to an incomplete setup of the basic colorbox module. To understand more, can you please share all the settings of your field like in particular what field type that is and which Style of colorbox you selected?

Comment #3

5 July 2017 at 13:11

jurgenhaas committed 3e421ae on 7.x-1.x

Issue #2892182 by jurgenhaas: Strict warning: Only variables should be...

Comment #4

morybel CreditAttribution: morybel commented 5 July 2017 at 19:22

File	Size
display0.PNG	2.54 KB
display1.PNG	6.46 KB
display2.PNG	13.16 KB

My field is an entity reference type, referencing a node. This node is simply a location where to buy the product (a store).

I'm using Display suite to manage my display. Whatever I choose, iframe is always on.

display1

Whey I check the source code within Chrome, I see this.

Uncaught TypeError: Cannot read property 'split' of undefined
    at Function.$.urlParams (colorbox_load.js:27)
    at HTMLDivElement.<anonymous> (colorbox_load.js:49)
    at Function.each (jquery.min.js:3)
    at $.fn.init.each (jquery.min.js:3)
    at $.fn.init.$.fn.once (jquery.once.js:55)
    at Object.attach (colorbox_load.js:48)
    at Object.<anonymous> (drupal.js:76)
    at Function.each (jquery.min.js:3)
    at Object.Drupal.attachBehaviors (drupal.js:74)
    at HTMLDocument.<anonymous> (drupal.js:557)