If possible, can another install location be allowed next to /libraries. E.g. to be able to include colorbox in an install profile, without additional requirements on the site including the install profile (e.g. adapt composer.json).
This has been done in dropzonejs for reference.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daften created an issue. See original summary.

daften’s picture

daften’s picture

Should the library definition be updated to be defined with https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21... ?

daften’s picture

Status: Active » Needs review
FileSize
957 bytes

A patch for the proposed changes.

geophysicist’s picture

daften’s picture

There is no dependency on libraries for colorbox, so the latest patch is not OK IMO.
Libraries support should be in a separate issue and should use libraries to the fullest. Or there should be an adaptation in the README file which explains that other locations are supported, but only with the libraries module installed.
Also, minified => false is the default, so doesn't need to be added explicitly.

Anonymous’s picture

Status: Needs review » Needs work
Neslee Canil Pinto’s picture

Status: Needs work » Closed (won't fix)