Replacing t function with $this->t in class file

CommentFileSizeAuthor
#8 2755773-translation-trait-8.patch634 bytesSam152
#4 replace-direct-call-of-t-function-in-ClassFile.patch29.45 KBChandan Chaudhary
replace-direct-call-of-t-function-in-ClassFile.patch29.45 KBChandan Chaudhary
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chandan Chaudhary created an issue. See original summary.

Chandan Chaudhary’s picture

Chandan Chaudhary CreditAttribution: Chandan Chaudhary as a volunteer and commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, replace-direct-call-of-t-function-in-ClassFile.patch, failed testing.

Chandan Chaudhary’s picture

Chandan Chaudhary CreditAttribution: Chandan Chaudhary as a volunteer and commented
Status: Needs work » Needs review
FileSize
replace-direct-call-of-t-function-in-ClassFile.patch29.45 KB

Status: Needs review » Needs work

The last submitted patch, 4: replace-direct-call-of-t-function-in-ClassFile.patch, failed testing.

  • frjo committed d6dbe63 on 8.x-1.x authored by Chandan Chaudhary 
    Issue #2755773 by Chandan Chaudhary: Replacing t function with $this->t...
frjo’s picture

frjo CreditAttribution: frjo commented
Category: Support request » Task
Status: Needs work » Fixed

Committed, thanks for the contribution.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Fixed » Needs review
FileSize
2755773-translation-trait-8.patch634 bytes

This failed the tests and broke most of the functionality in HEAD. Attaching a patch to fix.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Needs review » Fixed

  • Sam152 committed baa4fb7 on 8.x-1.x 
    Issue #2755773 by Sam152: Replacing t function with $this->t in class...
frjo’s picture

frjo CreditAttribution: frjo commented

Thanks @Sam152 for fixing this!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.