CommentFileSizeAuthor
#5 colorbox-use-entity-id-2692235-5-D8.patch836 byteskruhak
#2 colorbox-use-entity-id-2692235-D8.patch426 byteskruhak

Comments

kruhak created an issue. See original summary.

kruhak’s picture

kruhak commented
StatusFileSize
new colorbox-use-entity-id-2692235-D8.patch426 bytes
sam152’s picture

sam152 commented
Status: Active » Needs review

Needs review for the testbot.

Status: Needs review » Needs work

The last submitted patch, 2: colorbox-use-entity-id-2692235-D8.patch, failed testing.

kruhak’s picture

kruhak commented
Status: Needs work » Needs review
StatusFileSize
new colorbox-use-entity-id-2692235-5-D8.patch836 bytes

Hello, Sam152

Updated patch attached. If I properly understand then module trying use bundle of entity for automatically generate gallery identifier, but for token replacement should be used entity id as array key, instead of bundle.

P.S. As I see tokens functionally doesn't covered by test. May be better create new issue for this? What do you think?

  • frjo committed 0fb008d on 8.x-1.x authored by kruhak 
    Issue #2692235 by kruhak: Tokens in custom caption/gallery not being...
frjo’s picture

frjo commented
Status: Needs review » Fixed

Committed, thanks for the contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.