After applying the proposed patch https://www.drupal.org/node/2646540
I've got this error: Recoverable fatal error: Argument 9 passed to Drupal\colorbox\Plugin\Field\FieldFormatter\ColorboxFormatter::__construct() must be an instance of Drupal\colorbox\PageAttachmentInterface, instance of Drupal\colorbox\ColorboxAttachment given

CommentFileSizeAuthor
#8 colorbox-2648424-7.patch2.31 KBSam152
#2 colorbox-2648424-8.0.2.patch1.67 KBemanuelrighetto
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

emanuelrighetto created an issue. See original summary.

emanuelrighetto’s picture

emanuelrighetto CreditAttribution: emanuelrighetto commented
FileSize
colorbox-2648424-8.0.2.patch1.67 KB

I solved with the attached code

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
CreditAttribution: rodrigoaguilera at Ymbra commented

Solved it for me too. Thanks :)

glynster’s picture

glynster CreditAttribution: glynster commented

+1 RTBC colorbox now working!

Sam152’s picture

Sam152 CreditAttribution: Sam152 commented
Status: Active » Needs review

Testbot ahoy.

Sam152’s picture

Sam152 CreditAttribution: Sam152 commented

Looks like the tests picked this up already. The HEAD results are here: https://www.drupal.org/pift-ci-job/132870

Status: Needs review » Needs work

The last submitted patch, 2: colorbox-2648424-8.0.2.patch, failed testing.

Sam152’s picture

Sam152 CreditAttribution: Sam152 commented
Status: Needs work » Needs review
FileSize
colorbox-2648424-7.patch2.31 KB

This should pass.

Sam152’s picture

Sam152 CreditAttribution: Sam152 commented
Sam152’s picture

Sam152 CreditAttribution: Sam152 commented
Status: Needs review » Fixed

The patch was good, just needed hinting to ElementAttachmentInterface. This seemed to be working before, just with an error in the logs. Anyway, now that it's green it can go in, thanks for your contribution.

  • Sam152 committed 6429cc9 on 8.x-1.x 
    Issue #2648424 by emanuelrighetto, Sam152: FieldFormatter

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.