I like the idea of keeping colorbox a lean module and creating other modules to support functionality that the Drupal 7 module supported.

I do however think for the sake of continuity for the 250k installs in D7, we should clearly document which contrib modules provide each of these bits of split out functionality and also co-ordinate any stable releases of these modules with a tagged version of the base module.

After this has all been determined, making this clear on the module page will hopefully ensure some continuity between D7 and 8.

CommentFileSizeAuthor
#2 Screen Shot 2015-12-31 at 12.05.55 am.png147.2 KBSam152
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Issue summary: View changes
FileSize
Screen Shot 2015-12-31 at 12.05.55 am.png147.2 KB

For what it's worth, I've written a possible implementation of the colorbox_load contrib module here: https://www.drupal.org/sandbox/sam/2642446. Still sorting out some patches for it's dependencies, but it displaying content in a colorbox modal window after an AJAX call:

It integrates with ng_lightbox so works a little differently than the D7 version from memory. The interface is a list of the URLs, then any links to those paths are altered to be modals. Eg, if you enter 'node/*', any node link will open in an AJAX modal window.

This potentially covers colorbox_node as well as colorbox_load. Would be interested to hear if the colorbox_node maintainer is interested in chiming in. I think _load is a better namespace for a totally generic module than _node, with the obvious more narrow namespace, but I'll concede it already has lots of installs.

iLLin’s picture

iLLin CreditAttribution: iLLin commented

Hey Sam, been really busy. I haven't put a ton of thought into D8 yet, but I don't mind changing the name for D8 to have it make more sense. That module started out just supporting nodes and then got fancy with the menu callback system, which I feel still needs more work. Is your idea to include "Colorbox Load" as a submodule with its own project page? What are looking for from me?

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

If you are busy and aren't interested in maintaining the 8.x version of this feature, I totally understand. I think a rough plan for this would be to:

  1. Decide on an approach and review the sandbox to see if it solves the problem.
  2. Create a new project called "Colorbox Load" to match the name of the D7 feature and to also cover existing functionality of "Colorbox Node".
  3. Document how and where users can leverage this feature, now that it's no longer part of the core of the colorbox module.

I can go ahead with these steps if it that works for you? I just didn't want to release something if you were planning on working on your module.

iLLin’s picture

iLLin CreditAttribution: iLLin commented

Sam,

I didn't say I wasn't interested, just that I have been busy. Now that I am thinking about this, I'll pose a different question. The colorbox node gets its functionality from the built-in AJAX framework. It really isn't dependent on colorbox, or any other modal library for that matter. I wonder instead of pigeonholing it to colorbox, maybe it's used more of a helper and can plug any modal box library into it. So now we have a helper module that will present any menu callback into a modal box of your choosing. Thoughts?

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

Hi illin,

Great point, have you cloned the sandbox I linked? Core already has a concept in core called "main content renderers". Out of the box, it has a modal library in core which can open any content automatically. This is all that the colorbox_load module is. I also have a dependency on ng_lightbox which provides a simple path based interface for defining which URLs should appear in the modal window. The issue to make ng_lightbox pluggable is here: #2642460: Allow a pluggable or alterable dialog-type to allow ng_lightbox to be a dependency of colorbox_load.

iLLin’s picture

iLLin CreditAttribution: iLLin commented

Ok, I will need to get more up to speed with D8 on the changes you mentioned. I know ctools tries to do this, but that module is just way to large and cumbersome for something this simple. When I have time to read up on D8, I will be better versed to provide better ideas.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

I am going to create and publish colorbox_load. If you'd like to get involved from there, ping me and we can sort out any access and links from colorbox_node.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

Does anyone know the scope of colorbox_inline and what a contrib solution for this would look like? I might have a dig in the D7 version and work it out.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

colorbox_inline and colorbox_load are done and with dev versions, have updated the module page. I think this can be considered fixed?

Thanks for everyone's help and input.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Active » Fixed
frjo’s picture

frjo CreditAttribution: frjo commented

Have made a stable release now, 8.x-1.0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.