Problem/Motivation

The ranges in the admin form are hard coded arrays which can be prone to errors.

Proposed resolution

Replace them with a range function.

Remaining tasks

Patch.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 2642382-range-options-with-method.patch3.83 KBSam152
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
FileSize
2642382-range-options-with-method.patch3.83 KB

Patch depends on #2642380: Use states API for the admin form instead of custom JavaScript toggles..

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2642382-range-options-with-method.patch, failed testing.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Needs work » Needs review

  • frjo committed 584bc78 on 8.x-1.x authored by Sam152 
    Issue #2642382 by Sam152: Replace range options in the admin from with a...
frjo’s picture

frjo CreditAttribution: frjo commented
Status: Needs review » Fixed

Nice solution, Drupal should have a optionsRange function built in.

Committed to 8-dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.