2.10 added random custom gallery token and the gallery won't show all the images, after clicking the "Load more" button.
On the page 2 galleries will be created: one for the images displayed by default and another gallery that contains images loaded with the "Load More" functionality.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

oana.hulpoi created an issue. See original summary.

frjo’s picture

Title: Bug with 2.10 update and "Views Load More" pager module » Problem with 2.10 update and "Views Load More" pager module
Assigned: Unassigned » frjo
Category: Bug report » Task

The security team decided that this changes was needed from a security perspective. I would rather not have implemented it.

I plan to add an option to disable it, with some warnings to make the security team happy.

oana.hulpoi’s picture

Just that we need a solution for this kind of situations... when we add dynamic content to existing galleries and we want to keep the functionality. And not create 2 or more galleries every time new content is loaded.
Thanks for your quick answer :)

frjo’s picture

Please try out this patch. It adds a "Unique per-request gallery token" settings under "Advanced settings" section on the Colorbox configuration page.

frjo’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: colorbox_gallery_token_setting_2613200.patch, failed testing.

oana.hulpoi’s picture

Thank you! I tested the patch, it removes the token if "Off" and it works :)
What about the security implications? Do you think that, for some cases (like the one described above), we can re-use a token that already exists on page, maybe with javascript?

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: colorbox_gallery_token_setting_2613200.patch, failed testing.

  • frjo committed a9a2bd7 on 7.x-2.x
    Issue #2613200 by oana.hulpoi: Problem with 2.10 update and Views Load...
frjo’s picture

Status: Needs work » Fixed

Committed to 7-dev now, thanks for testing!

There is only a security issue (of sort) if you have comments on the same page and allow users to use link and image tags there.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.