D8Beta6 Enabled Colorbox
Fatal error: Class Drupal\colorbox\Form\ColorboxSettingsForm contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Drupal\Core\Form\ConfigFormBase::getEditableConfigNames) in /home/d8green/public_html/modules/colorbox/src/Form/ColorboxSettingsForm.php on line 350

CommentFileSizeAuthor
#5 2421907-5.patch1.16 KBj4
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

frjo’s picture

frjo CreditAttribution: frjo commented
Title: Install Fatal Error » Install Fatal Error D8 beta 6

Thanks for the report.

New stuff seems to break with each beta, I will most likely wait for beta 7 before I do anything more.

GreenSkunk’s picture

GreenSkunk
Location Great Valley, NY
CreditAttribution: GreenSkunk commented

@frjo have you seen @AlexPott's Change record "Configuration objects by default are immutable."
It works after adding the following within the class "ColorboxSettingsForm" in ColorboxSettingsForm.php

protected function getEditableConfigNames() {
  return [
    'colorbox.settings',
  ];
}

I will learn how to make patches.

j4’s picture

j4 CreditAttribution: j4 commented

Hi,

Could you tell us exactly which line number you added this to?

After adding it I get an error while trying to save colorbox settings, though the other error has disappeared.

Drupal\Core\Config\ImmutableConfigException: Can not set values on immutable configuration colorbox.settings:custom.style. Use \Drupal\Core\Config\ConfigFactoryInterface::getEditable() to retrieve a mutable configuration object in Drupal\Core\Config\ImmutableConfig->set() (line 34 of C:\Users\Hp\Sites\devdesktop\drupalbangalore-dev\docroot\core\lib\Drupal\Core\Config\ImmutableConfig.php).

Thanks
Jaya

j4’s picture

j4 CreditAttribution: j4 commented

Hi

Changing

$config = $this->configFactory->get('colorbox.settings');

to

$config = \Drupal::configFactory()->getEditable('colorbox.settings');

removes the above error and allows me to save the configuration settings.
But colorbox doesnt work yet.

Thanks
Jaya

j4’s picture

j4 CreditAttribution: j4 commented
FileSize
2421907-5.patch1.16 KB

Hi,

Thanks to my mentor Hussain Deghamwala (https://www.drupal.org/u/hussainweb), my first patch in drupal.org!

GreenSkunk’s picture

GreenSkunk
Location Great Valley, NY
CreditAttribution: GreenSkunk commented

Great job @j4 for further testing and a patch!

frjo’s picture

frjo CreditAttribution: frjo commented
Status: Active » Fixed

And committed to 8-dev, thanks for the contribution and testing!

  • frjo committed 705a816 on 8.x-1.x authored by j4 
    Issue #2421907 by j4: Install Fatal Error D8 beta 6
frjo’s picture

frjo CreditAttribution: frjo commented

@j4, here is your first commit https://www.drupal.org/user/242456/track/code, the first of many I hope!

j4’s picture

j4 CreditAttribution: j4 commented

Thank you! Glad to have contributed a miniscule drop in the Drupal ocean!! :)

Jaya

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.