Any chance of backporting #2250087: Add Toolbar icon for Coffee to Drupal 7 navbar?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lsolesen created an issue. See original summary.

michaelmol’s picture

Sounds like a great idea. Do you have an idea where to place it?

lsolesen’s picture

Same place as in D8 maybe?

willzyx’s picture

Sounds like an excellent idea! the attached patch integrate coffee and navbar module

here the result:



willzyx’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: backport_add_navbar-2704823-4.patch, failed testing.

willzyx’s picture

Status: Needs work » Needs review

the failure are caused by

* ERROR: No valid tests were specified.
and
* ERROR: Step ?Publish JUnit test result report? failed: None of the test reports contained any result

this means that the testbot fails because there are not tests for coffee 7.x

moving to NR

michaelmol’s picture

I have disabled the automated tests for the 7.x branch, so it should be ok now.

  • willzyx authored b352b9e on 7.x-2.x
    Issue #2704823 by willzyx, lsolesen, michaelmol: Backport add navbar...
michaelmol’s picture

Status: Needs review » Fixed

Commited in 7.x-2.x

lsolesen’s picture

Status: Fixed » Active

I've implemented the latest dev-version of coffee on my site. I can access coffee using alt + d, but there is no menu item in the navbar menu. Does this work for you guys?

I've cleared my cache twice and logged in and out as user 1. I also gave permissions to the user roles and tried another user role.

michaelmol’s picture

@isolesen did you install the navbar module?

lsolesen’s picture

Yeah, I have the navbar module installed :)

willzyx’s picture

Status: Active » Fixed

@lsolesen this work perfectly for me :)
please can you check if the relevant part of the patch (the coffee.navbar.inc file and the chenges in coffee.js) are present in your module installation? if they are not probably you are using an older version of coffe that not contains the navbar integration

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.