Problem/Motivation

There is no composer.json file found in module. Please see https://www.drupal.org/node/2514612

Proposed resolution

Add the composer.json file.

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rakesh.gectcr created an issue. See original summary.

rakesh.gectcr’s picture

Status: Active » Needs review
FileSize
1.34 KB
willzyx’s picture

@rakesh.gectcr thanks for the patch! a quick review:

  1. +++ b/composer.json
    @@ -0,0 +1,46 @@
    +  "extra": {
    +    "branch-alias": {
    +      "dev-8.x-1.x": "8.1.x-dev"
    +    }
    

    is this really needed?

  2. AFAIK the standard is use an indent of 4 spaces for composer.json

naveenvalecha’s picture

Status: Needs review » Needs work
Issue tags: +Novice, +Needs reroll

for 4spaces

visabhishek’s picture

Status: Needs work » Needs review
FileSize
1.52 KB

Code updates as per #4.

rakesh.gectcr’s picture

Please check the other contributed modules, They are having only 2 space indentation,

Please see https://www.drupal.org/coding-standards#indenting

I agree composer.json file with 4 space indentation in general. I am not sure about Drupal. Correct me If i am wrong.

willzyx’s picture

Status: Needs review » Needs work

@rakesh.gectcr there are not explicit coding standards for composer.json files but 4 spaces is preferrable please see #2654894: Use an indent of 4 spaces for composer.json

  1. +++ b/composer.json
    @@ -0,0 +1,46 @@
    +        {
    +            "name": "Oliver Köhler",
    +            "homepage": "https://www.drupal.org/u/nebel54",
    +            "role": "Maintainer"
    

    mmm.. some encoding problem. This should be Oliver Köhler

poojasharmaece’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
1.52 KB

Updated as per #7

  • willzyx committed 4fc95dd on 8.x-1.x
    Issue #2677976 by rakesh.gectcr, poojasharmaece, visabhishek: Add the...
willzyx’s picture

Status: Needs review » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.