Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
There is no composer.json file found in module. Please see https://www.drupal.org/node/2514612
Proposed resolution
Add the composer.json file.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#8 | add_the_composer_json-2677976-8.patch | 1.52 KB | poojasharmaece |
| |||
#5 | add_the_composer_json-2677976-5.patch | 1.52 KB | visabhishek |
| |||
#2 | 2677976-1.patch | 1.34 KB | rakesh.gectcr |
|
Comments
Comment #2
rakesh.gectcrComment #3
willzyx CreditAttribution: willzyx commented@rakesh.gectcr thanks for the patch! a quick review:
is this really needed?
AFAIK the standard is use an indent of 4 spaces for composer.json
Comment #4
naveenvalechafor 4spaces
Comment #5
visabhishek CreditAttribution: visabhishek as a volunteer and at Azri Solutions commentedCode updates as per #4.
Comment #6
rakesh.gectcrPlease check the other contributed modules, They are having only 2 space indentation,
Please see https://www.drupal.org/coding-standards#indenting
I agree composer.json file with 4 space indentation in general. I am not sure about Drupal. Correct me If i am wrong.
Comment #7
willzyx CreditAttribution: willzyx commented@rakesh.gectcr there are not explicit coding standards for composer.json files but 4 spaces is preferrable please see #2654894: Use an indent of 4 spaces for composer.json
mmm.. some encoding problem. This should be Oliver Köhler
Comment #8
poojasharmaece CreditAttribution: poojasharmaece as a volunteer and commentedUpdated as per #7
Comment #10
willzyx CreditAttribution: willzyx commentedCommitted and pushed to 8.x. Thanks!