This fails on the core test suite in #1781422: Add search/jump/command functionality to toolbar.

CommentFileSizeAuthor
#5 interdiff.txt1.93 KBGábor Hojtsy
#5 2666008-5.patch3.02 KBGábor Hojtsy
#2 2666008.patch2.94 KBGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy created an issue. See original summary.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Active » Needs review
FileSize
2666008.patch2.94 KB

There you go :) I think you may want to swap out the project docs link to the project home page link for now, but should otherwise be complete?

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Status: Needs review » Reviewed & tested by the community

here we go

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Needs work 
+++ b/coffee.module
@@ -9,6 +9,29 @@ use Drupal\Core\Cache\Cache;
+      $output .= '<dd>' . t('Coffee only searches in the administration menu by default. You can configure support for any other menu on <a href=":admin-book">the Coffee configuration page</a>. It is also possible to set the number of displayed results to less or more than the default 7') . '</dd>';

This one somehow lost its endpoint, will fix now.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs work » Needs review
FileSize
2666008-5.patch3.02 KB
interdiff.txt1.93 KB

Fixed.

swentel’s picture

swentel CreditAttribution: swentel commented 
+++ b/coffee.module
@@ -9,6 +9,29 @@ use Drupal\Core\Cache\Cache;
+      $output .= '<p>' . t('The Coffee module offers quick navigation functionality as well as an extensible set of commands to let you jump around your site to desired pages very fast. The functionality is inspired by Alfred and Spotlight on Mac OS X. To active the feature, either press the Coffee button in the toolbar or use the Alt-D keyboard shortcut (Alt + Shift + D in Opera, Alt + Ctrl + D in Windows Internet Explorer). For more information, see the <a href=":coffee">online documentation for the Coffee module</a>.', array(':coffee' => 'https://www.drupal.org/documentation/modules/coffee')) . '</p>';

'To active' => 'To activate' ?

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Status: Needs review » Needs work

Thanks Gábor looks great! some observations:

  1. +++ b/coffee.module
@@ -9,6 +9,29 @@ use Drupal\Core\Cache\Cache;
+function coffee_help($route_name, RouteMatchInterface $route_match) {

    We need to add the 'use' statement for RouteMatchInterface or the Coffee help page throws a fatal error 

  2. +++ b/coffee.module
@@ -9,6 +9,29 @@ use Drupal\Core\Cache\Cache;
+      $output .= '<p>' . t('The Coffee module offers quick navigation functionality as well as an extensible set of commands to let you jump around your site to desired pages very fast. The functionality is inspired by Alfred and Spotlight on Mac OS X. To active the feature, either press the Coffee button in the toolbar or use the Alt-D keyboard shortcut (Alt + Shift + D in Opera, Alt + Ctrl + D in Windows Internet Explorer). For more information, see the <a href=":coffee">online documentation for the Coffee module</a>.', array(':coffee' => 'https://www.drupal.org/documentation/modules/coffee')) . '</p>';

    - As pointed by #6 'To active' => 'To activate'
    - We need to create the documentation page or the 'https://www.drupal.org/documentation/modules/coffee' link results in a 404

Great work :)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

I am not 100% sure that that path alias is allowed for contributed modules, are you aware of some policy somewhere? :)

willzyx’s picture

willzyx CreditAttribution: willzyx commented

Unfortunately no.. Can we point to coffee module page for now?

michaelmol’s picture

michaelmol CreditAttribution: michaelmol commented

I have removed the link, till we have a documentation page.

michaelmol’s picture

michaelmol CreditAttribution: michaelmol commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.