Third click mouse open new tab does'nt work anymore [#2010936]

Comment	File	Size	Author
#12	interdiff-10_12.txt	930 bytes	Cogax
#12	coffee-new-tab-2010936-12.patch	1.94 KB	Cogax

#10	coffee-new-tab-2010936-10.patch	1.82 KB	Cogax

#6	coffee-new-tab-2010936-4.patch	622 bytes	Cogax

#4	imce_search-search-tab-translated.patch	433 bytes	Cogax

Comment #1

michaelmol CreditAttribution: michaelmol commented 15 November 2013 at 14:30

Issue summary:	View changes
Status:	Active	» Postponed (maintainer needs more info)

Since I don't have a third mouse button, it is very hard to test it myself.
Can you please give me some more details, about what browser / os you are using?

Log in or register to post comments

Comment #2

Musa.thomas

French

France 🇫🇷

CreditAttribution: Musa.thomas commented 20 November 2013 at 16:45

using chrome Version 32.0.1700.14 beta-m Aura Windows 7

Log in or register to post comments

Comment #3

michaelmol CreditAttribution: michaelmol commented 28 March 2014 at 09:00

Status:

Postponed (maintainer needs more info)

» Closed (won't fix)

Log in or register to post comments

Comment #4

Cogax CreditAttribution: Cogax commented 30 October 2014 at 09:37

Status:	Closed (won't fix)	» Needs review
Related issues:		+#2366021: Open link in a new tab or window

File	Size
imce_search-search-tab-translated.patch	433 bytes

So i use also Chrome and it still not works. I made a little change in the Javascript, but i don't have the time to look if thats the right way to fix it. I attached the patch.

Edit: It's the wrong patch attached, sorry. See right bellow

Log in or register to post comments

Comment #7

michaelmol CreditAttribution: michaelmol commented 15 December 2014 at 21:08

Status:

Needs review

» Fixed

Added href in the result window, should now be clickable with the third mouse button.

Log in or register to post comments

Comment #9

29 December 2014 at 21:14

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #10

Cogax CreditAttribution: Cogax commented 6 October 2015 at 07:31

Version:	7.x-2.0	» 7.x-2.x-dev
Status:	Closed (fixed)	» Needs review

File	Size
coffee-new-tab-2010936-10.patch	1.82 KB

1 file was hidden/shown/deleted

File	Size
coffee-new-tab-2010936-4.patch	622 bytes

Well, the solution wasn't good. The link was wrong because the link doesn't respect basePath.
I made a new Patch which removes the previous comitted changes and goes another way. I catched the middle mouse click event as well as the ctrlKey event to decide if it should open a new tab.