Upgrade Status report

Contributed projects

CKEditor CodeSnippet 8.x-1.6

Scanned on January 22, 2020.
1 error found. 1 warning found. Items categorized "Fix now" are uses of deprecated APIs from community unsupported core versions.
Status File name Line Error
Fix now modules/contrib/codesnippet/codesnippet.module 40 Call to deprecated method entityManager() of class Drupal. Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Use \Drupal::entityTypeManager() instead in most cases. If the needed method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the deprecated \Drupal\Core\Entity\EntityManager to find the correct interface or service.
Check manually modules/contrib/codesnippet/codesnippet.info.yml 0 Add core_version_requirement: ^8 || ^9 to codesnippet.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#16 codesnippet.info.yml.rej_.txt302 bytesara martirosyan
#11 3108118-11.patch982 bytesankush_03
#8 3108118-8.patch982 bytessutharsan
#8 interdiff-3108118-5-8.txt532 bytessutharsan
#5 3108118-5.patch1001 bytesvoleger
#4 3108118-4.patch975 bytesankush_03
#3 3108118-Drupal-9-compatibility.patch994 bytesjulianvj

Comments

Anonymous’s picture

Anonymous (not verified) commented

Bwolf created an issue. See original summary.

julianvj’s picture

julianvj commented
Assigned: Unassigned » julianvj
Issue tags: +ContributionWeekend2020
julianvj’s picture

julianvj commented
StatusFileSize
new 3108118-Drupal-9-compatibility.patch994 bytes

Attached patch to fix Drupal 9 compatibility errors

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
Status: Active » Needs review
StatusFileSize
new 3108118-4.patch975 bytes

Added back the core: 8.x key because apparently it has to be there if the module can work with versions prior to 8.7.7

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Version: 8.x-1.6 » 8.x-1.x-dev
Priority: Normal » Major
StatusFileSize
new 3108118-5.patch1001 bytes

Projects with unsupported versions of Drupal core can patch modules to add missed 'core' key, but with core key is optional for supported and restricted for Drupal 9+ versions. Also without 'core_version_requirement' key composer not possible download module via composer.
We have Drupal 9 RC1 on the next week, a lot projects will try to upgrade their modules, so It would be better to apply patch ASAP.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Needs work

The only fix here is to use entityTypeManager(). This API has been in Drupal since 8.0.0, and as such this module would still support all versions prior to 8.7.7. As such, please keep the 'core' key.

sutharsan’s picture

sutharsan commented
Assigned: julianvj » sutharsan
Issue tags: +Drupal 9 porting weekend

Working...

sutharsan’s picture

sutharsan commented
Assigned: sutharsan » Unassigned
Status: Needs work » Needs review
StatusFileSize
new interdiff-3108118-5-8.txt532 bytes
new 3108118-8.patch982 bytes
sutharsan’s picture

sutharsan commented

Upgrade Status report after applying the patch

CodeSnippet, --
Scanned on Fri, 05/22/2020 - 12:40

No known issues found.
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs review » Reviewed & tested by the community

Thanks everyone for working on this!

Checked with the upgrade_status module on my local:

  1. Before: 1 error, 1 warning
  2. After: No known errors
+++ b/codesnippet.info.yml
@@ -3,6 +3,7 @@ type: module
\ No newline at end of file
+  - drupal:ckeditor

+1 to the newline added to the end of codesnippet.info.yml

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
StatusFileSize
new 3108118-11.patch982 bytes
jcnventura’s picture

jcnventura
Primary language English
commented

If #8 gets committed, please also credit @chipway as he did some work that is long RTBC over in #3000133: Update Dependencies for composer.

I'll leave to the maintainer whether #11 is a valid contribution or not.

  • Sutharsan authored 110d90a on 8.x-1.x 
    Issue #3108118 by ankushgautam76@gmail.com, Sutharsan, JulianVJ, voleger...
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Reviewed & tested by the community » Fixed
klemendev’s picture

klemendev commented

Now that D9 is out, there might be a good point to make a stable release compatible with it :)

ara martirosyan’s picture

ara martirosyan commented
StatusFileSize
new codesnippet.info.yml.rej_.txt302 bytes

the patch #11 gets rejected on codesnippet.info.yml

kevinquillen’s picture

kevinquillen commented

Wanted to note I am using this on my personal D9 site and it works!

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

+1 on release a new tag. The last one was from 2016!

ara martirosyan’s picture

ara martirosyan commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.