coder 7.x-1.0

Changes since 7.x-1.0-beta6 release:

• issue #530698 by maartenvg: Fixed Wrongful suggestion to use db_query_range() on LIMITed DELETE FROM.
• added in more comments
• issue #1227748 by kasperg: Fixed Code review Drush task does not pipe output.
• issue #1224618 by fgm: Fixed Coder throws warnings under 5.3.
• issue #858330 - merged in checkstyle xml output
• issue #1230308 by kasperg: Fixed Invalid XML ouput.
• Refactor settings form to use vertical tabs.
• Enhance checks for properly installed module and library.
• Strip comments from another value.
• Enable global value of filename being converted.
• Move version-agnostic routines to new file.
• Add check for orphaned input directory.
• Escape user input.
• Update API documentation; add missing t() call.
• Issue #853582 by sun: Fixed 'else if' is not changed into 'elseif'.
• Stripping Id tags.
• Remove unintended debug statement.
• Ticket #858330 by Kender, zroger, harijari, stella - added in support for drush coder-review xml output
• Issue #1019694 by Jody Lynn - fixed spelling typos
• Issue #178629 by sun - fixed @see reviews.
• removed update_sql refs
• removed D6 security rules
• Merge branch 'master' of git.drupal.org:project/coder
• newer d6 to d7 tests
• #1106538: Use drupal_parse_info_file(); #1106544: Reflect reverted registry change.
• Check for Grammar Parser installed as a module and wrong version of Libraries API.
• Reanable use of separate process (with parser in libraries directory).
• Load parser from new library location.
• Replace dependency on Grammar Parser with Grammar Parser Library and Libraries modules.
• Include files needed for install (missed after renaming files and moving content).
• Move routines to new or more appropriate files; revise @file comments; correct typos; delete blank line at top of each file.
• Issue #1115802: correct syntax errors caused by input file; still leaves dangling else block.
• Rename files; correct typos; modify help text; update copyright; move coder_upgrade_path(); eliminate include.
• Change default value of 'coder_upgrade_use_separate_process' to FALSE.
• Modify hook_upgrade_info() to allow multiple upgrade sets per module.
• Open log and patch files in new window.
• Remove unnecessary include file.
• Fix indention.
• Replace calls to is_a() by instanceof operator.
• Issue #1008256, #224333#registry: The files listed in an info file should only include those that declare a class (or interface).
• fixed #cache warnings
• merged in additional reviews
• #990940 - $Id rule inverted
• fixed ignores warnings
• fixed security tests
• Fixed comment tests
• removed $Id line
• by douggreen - fix for unit tests failing
• fixed #cache logic
• allow modules to alter the coder args and implement a hook to run before results are displayed
• Stripping CVS keywords
• #859314: minor cleanup to conform to Drupal coding standards.
• coder_upgrade.end.inc: ignore all hidden directories and exclude template files.
• #859314: rename global variables according to Drupal coding standards.
• coder_upgrade.module: #1010762 by Placinta: fix inconsistent return value in coder_upgrade_conversions_apply().
• fix for review_name undefined warnings
• added in latest links
• Added in core=7.x check
• stub file
• Added in doxygen comment review for .install files.
• updated log with coding style fixes
• coding style changes
• #859314 by duellj - coding style fixes
• #906200 by drupal-id.com - moved code below @file comment
• #589038 - drupal_set_session() change was reverted. Updated the warning and set it to minor
• #912490 by arithmetric - fix for api theme calls called incorrectly
• #704032 by fgm - fix for module_implements vs module_list incorrect warnings
• various files: replace calls to pgp_log_memory_use() with coder_upgrade_memory_print(); coder_upgrade.module: #982380: correct coder_upgrade_parameters_save() to use module directory instead of files directory, enhance coder_upgrade_conversions_apply() to capture errors and return code; coder_upgrade.main.inc: refactor print routines to use coder_upgrade_path_print(); coder_upgrade.run.php: enhance documentation; coder_upgrade.test: refactor getInfo() routines; tests/samples directory: update the input and expected test file: example.module.
• #976940: eliminate php warnings related to files not present: core.coder_review_ignores.txt and info file.
• coder_upgrade.main.inc: #245471 (comment #7): remove base directory path from patch file in coder_upgrade_make_patch_file(); inc, install, help.inc, main.inc, module, test: refactor file_directory_path() references to coder_upgrade_directory_path(); coder_upgrade.run.php: add php memory and time limits.
• #954256 by superbaloo - fix for paths of files within the ignore file
• changed some help text
• fixed path to core.coder_review_ignores.txt
• #948124 by boombatower - added in ability to review individual files
• changed some drupal_set_message() messages to be errors
• #946978 by boombatower - added severity name to drush output
• Fix missing required code file for install.
• coder_upgrade.install: fix call requiring a variable to be passed by reference.
• File missed in previous commit.
• coder_upgrade.module: refactor form submission code to coder_upgrade_conversions_apply().
• Another file missed in previous commit.
• File missed in previous commit.
• coder_upgrade.inc, coder_upgrade.install, coder_upgrade.module, coder_upgrade.main.inc: refactor code to allow execution from a separate process outside of Drupal; coder_upgrade.begin.inc: cache the core theme information in the persistent cache (includes disabled modules).
• coder_upgrade.db.inc: enhance error handling by checking for conditions not being found in a select query; coder_upgrade.call.inc, coder_upgrade.function.inc: enhance #theme_changes to check number of parameters to theme_xxx() and hook_theme entry; coder_upgrade.function.inc: enhance #theme_changes when setting theme key to 'render element' also change value from an associative array to a string.
• fixed some theme warnings
• fixed more undefined index warnings
• fixed some warnings
• coder_upgrade.install: hook_uninstall(): delete recently added settings variables, hook_requirements(): use get_t().
• coder_upgrade.function.inc: refactor #hook_permission to hook_upgrade_hook_perm_alter(), refactor #descriptions_permissions to use the convert_return() pattern (use cases 1 and 2), refactor doc_comment checking in coder_upgrade_convert_update_N() to revert to that in hook_upgrade_hook_alter(); tests/samples directory: update the input and expected test file: example.module.
• coder_upgrade.inc: define file_directory_path() in response to its removal from core; coder_upgrade.db.inc, coder_upgrade.function.inc: coding style fixes.
• #895708 - fix for broken function names
• coder_upgrade.function.inc: enhance #hook_filter_info (including a missed parser API change that broke the entire routine), #install-schema, #hook-user-changes, #hook_load_signature, and #theme_changes.
• strengthened db_rewrite_sql rule
• tweaked db_rewrite_sql() rule
• fixed errors
• FAPI reviews
• coder_upgrade.module: improve the menu integration when only Coder Upgrade is enabled, only allow the base files directory to be renamed, enable the submit handler for the settings form; coder_upgrade.main.inc: refactor the coder_upgrade_xxx_path() routines to reflect the coder_upgrade_dir variable.
• hardened a rule
• checks for fapi #title and #description
• checks on hook_block() title
• added in links to docs
• check for form tags
• added in checks for eval() and drupal_eval()
• added in $_POST check
• generic php.net url
• fixed parsing error for blank lines in ignores file
• added filter_xss() to list of sanitizing functions
• additional security reviews for trigger_error(), form_set_error(), form_error() and confirm_form()
• updated _coder_modified() check
• strengthened some rules to reduce false positives
• modified REQUEST_URI rule so it doesn't check within the request_uri() function itself.
• Missed in previous commit.
• coder_upgrade.db.inc: enhance coder_upgrade_insert_dbtng_statement() to properly insert statements; coder_upgrade.function.inc: enhance coder_upgrade_op_to_hook() to not use clone and to allow for more than one case statement with no body; tests/samples directory: update the input and expected test file: example.module.
• #881690 by duellj - fix for typo
• coder_upgrade.call.inc:#878470: enhance #drupal_set_header_renamed to handle no parameters; coder_upgrade.function.inc: enhance #hook_load_signature to clean the parameter variable; coder_upgrade.list.inc: add routine entry for grammar parser; coder_upgrade.main.inc, coder_upgrade.module: implement settings for preserving array format and debug output by coder upgrade and grammar parser.
• #311259 - added in ability to disable warnings by rule set (security, style, etc) per line. See core.coder_review_ignores.txt for an example - just replace 'core' with your module name.
• strengthened the db_rewrite_sql() and drupal_set_title/message() tests to reduce false positives - added in multi-line review functionality, forward and back.
• #328362 - strengthened the checks by adding in multi-line reviews to ensure $var isn't sanitized on previous lines in the same function, should reduce false positives.
• #319489 - added in link
• #319489 by stella - changed priority level of l() already contains check_plain()
• #328362 by greggles, stella #318763 by john morahan, stella #752734 by john morahan, stella #301552 by douggreen, stella
• coder_upgrade.db.inc: improve sql parsing and conversion to DBTNG syntax; coder_upgrade.begin.inc: refactor call to coder_upgrade_convert_return() and associated callback; coder_upgrade.function.inc: enhance coder_upgrade_convert_op() to use new getParameterVariable() API function, refactor the convert return pattern of routines: coder_upgrade_convert_return(), coder_upgrade_convert_return_loop(), and coder_upgrade_callback_return_caseN(); tests/samples directory: update the input and expected test file: example.module.
• coder_review_7x.inc: #704018 by jhodgdon - spelling/grammar error.
• coder_upgrade.api.php: update documentation to reflect the node being returned by getFunctionCalls(); coder_upgrade.db.inc: improve sql parsing and conversion to DBTNG syntax.
• coder_upgrade.call.inc, coder_upgrade.main.inc: revise code to reflect change to PGPReader::getFunctionCalls() which now returns a list of nodes; coder_upgrade.call.inc: enhance #comment_node_url, #taxonomy_form_all, and #update_sql to utilize the node now returned by getFunctionCalls().
• coder_upgrade.call.inc: #update_sql, #847914: drupal_get_form() upgrade routine fails when form callback has no parameters; coder_upgrade.function.inc; #837258: add T_ELSE_IF to condition check in coder_upgrade_convert_op(), #update_sql: changes to hook_update_N().
• coder_upgrade.test: include function.inc needed by begin.inc; tests/samples directory: update the input and expected test file: example.module (in previous commit).
• coder_upgrade.db.inc: improve sql parsing and conversion to DBTNG syntax (by duellj and adrian); coder_upgrade.call.inc: improve #drupal_set_title to only find calls to check_plain(), improve #user_load_multiple to handle inline comments in parameters; coder_upgrade.function.inc: #833972: conform doc_comment to Drupal standards for inserted hook_op functions, add a doc_comment to each function missing one.
• coder_upgrade.call.inc: #db_is_active, #remove-drupal-urlencode, improve #user_load_multiple to not always change call to user_load_multiple().
• coder_upgrade.call.inc: #taxonomy_form_all; coder_upgrade.function.inc: #node_form, #drupal_render_children; coder_upgrade.regex.inc: #block_tables_renamed, #fapi_changes.
• coder_upgrade.main.inc: enhance cdp() to allow for a description; coder_upgrade.regex.inc: implement #taxonomy_tables; tests/samples directory: update the input and expected test file: example.module.
• coder_upgrade.module: enable customization of the module conversion form steps (build, validate and submit); coder_upgrade.main.inc: include function reference in patch file (diff -up)
• coder.module, coder_review.module, coder_upgrade.module: #776996, #824268: eliminate strict warning in coder_review_page(), #636608: move settings menu items to local task of Review, #824320: eliminate warnings when only one of the Review or Upgrade modules is enabled; coder_upgrade.test: #820140: undefined DEADWOOD_OLD
• coder_upgrade.call.inc: Implement #db_column_exists, improve #file_set_status; coder_upgrade.regex.inc: Implement #watchdog_emerg.
• coder_upgrade.begin.inc, coder_upgrade.call.inc: Implement #hook_forms_signature; coder_upgrade.function.inc: Implement #hook_forms_signature, #hook_load_signature, #hook-user-changes.
• coder_upgrade.call.inc: #db_result (not documented), #no-synonyms-taxonomy, #node_load_multiple (by duellj with modifications); coder_upgrade.function.inc: Improve coder_upgrade_callback_theme() to handle empty array as arguments parameter; coder_upgrade.regex.inc (by duellj): #remove_FILE_STATUS_TEMPORARY.
• copy the "Submit" button check from the 6.x upgrade to the style review
• coder_upgrade.begin.inc, coder_upgrade.call.inc: #765070: allow for a theme without variables; coder_upgrade.function.inc: Improve coder_upgrade_convert_op() to extract the $op variable from the parameter, Improve coder_upgrade_callback_block to find quoted numeric deltas; coder_upgrade.install.inc: 765070: improve regex in convert_install_file_comment().
• coder_upgrade.call.inc, coder_upgrade.regex.inc (by duellj with modifications): Implement #drupal_add_js_external, #jquery_ui, and #custom_block.
• tests directory: Update the input and expected test file: example.module.
• coder_upgrade.call.inc: Restore missed calls to PGPArray::findValue(); coder_upgrade.test: Refactor setup method to run the theme caching before starting the test method.
• coder_upgrade.begin.inc: Fix recursive calls in coder_upgrade_cache_hook_theme(); coder_upgrade.call.inc: Implement #form_clean_id and #file_prepare_directory, improve #http_header_functions; coder_upgrade.end.inc: Fix recursive calls in coder_upgrade_add_file_entries(); coder_upgrade.function.inc: Fix calls to PGPList::searchCallback, fix missed T_RETURN statements changes in coder_upgrade_convert_schema() and coder_upgrade_convert_perm(), utilize PGPReader::setPreserveArrayFormat() (with latest modification to ignore whitespace).
• d7 automatically does schema
• coder_upgrade.call.inc: Implement #drupal_add_css_inline, and #admin_path_changes; coder_upgrade.regex.inc: Implement #admin_path_changes.
• coder_upgrade.call.inc: Implement #drupal_goto_params, revise #url_query_parameter; coder_upgrade.function.inc: Implement #implementation_hook_comment and #hook_element_info.
• coder_upgrade.db.inc: Disable db_query routine untill it is more robust; coder_upgrade.call.inc: Implement #user_load_multiple; coder_upgrade.function.inc: Refactor coder_upgrade_convert_return pattern to loop on conditional statements.
• coder_upgrade.call.inc: Implement #theme_page; coder_upgrade.function.inc: Refactor routines to use new coder_upgrade_convert_return pattern: #trigger_overhaul: hook_action_info, hook_hook_info; #node_type_base: hook_node_info.
• Added configure paramter.
• coder_upgrade.help.inc: Update documentation.
• coder_upgrade.begin.inc: New file to handle module preprocessing; coder_upgrade.function.inc: Restore hook_install_alter, implement new coder_upgrade_convert_return and use with #theme_alter; coder_upgrade.module: Enhance coder_upgrade_module_list to use with theme registry caching; coder_upgrade.install.inc: #728252: Array error when checking for @file in install files; coder_upgrade.api.php: Update documentation.
• coder_upgrade.call.inc: #727242, #727248 by duellj: Implement #theme_pager, #theme_username.
• coder_upgrade.call.inc: #727234, #727226, #727220 by duellj: Implement #format_date, #menu_tree_data, #url_query_parameter; coder_upgrade.function.inc: #712722 by duellj: Implement #block_deltas_renamed.
• coder_upgrade.call.inc: #712696, #643192, #643186 by duellj: Implement #placeholder, #node_type_get_functions, #node_invoke_nodeapi; coder_upgrade.function.inc: Revise #remove_op: revert $build_mode to $view_mode in hook_nodeapi and hook_user.
• coder_upgrade.info, coder_upgrade.main.inc: Reflect the renamed grammar parser module; coder_upgrade.install, coder_upgrade.module: Minor cleanup; coder_upgrade.test, tests directory: Add these files.
• parse_ini_file expects the full path
• Update change log.
• call.inc: implement #drupal_set_header_renamed.
• function.inc: implement #node_type_base.
• function.inc: implement #node_links.
• function.inc: implement #trigger_overhaul (hook_hook_info portion).
• function.inc: implement #hook_filter_info.
• function.inc: implement #trigger_overhaul.
• main.inc: Refactor debug and log print to automatically call $object->print_r(), Add calls to pgp_log_memory_use.
• call.inc: implement #node_type_base (function call portion), update #theme_changes for parser changes.
• call.inc: implement #absolute_includes, #preg_match, #file_scan_directory_nomask, #file_scan_directory_property_names, #file_scan_directory_array_itize, #drupal_valid_path, implement hook_upgrade_call_alter for db_... function calls and #absolute_includes
• coder_upgrade.api.inc: Update API documentation for new alter hooks; coder_upgrade.main.inc: Add hook_upgrade_hook_alter, use old directory name in hook_upgrade_end_alter if files are being replaced.
• coder_upgrade.module, coder_upgrade.main.inc: Add setting to indicate whether to replace files.
• coder_upgrade.module: Add setting to run against core modules; coder_upgrade.list.inc, coder_upgrade.main.inc, coder_upgrade.module, coder_upgrade.end.inc, coder_upgrade.install.inc, coder_upgrade.regex.inc: Refactor the API to be totally hook based using drupal_alter; coder_upgrade.call.inc, coder_upgrade.function.inc: Remove first parameter from search function calls.
• coder_upgrade.install.inc: Add this file, implement #afile, #info_core_7; coder_upgrade.list.inc: Allow for array of files to be associated with a routine, add entries for install_file and info_file routines; coder_upgrade.db.inc: Add this file, start on #dbtng for non-select queries.
• coder_upgrade.api.inc: Update API documentation for new alter hooks; other non-conversion files: Update copyright years.
• coder_upgrade.list.inc, coder_upgrade.main.inc: Include files from new 'file' parameter; coder_upgrade.other.inc: Refactor function and function call routines to use drupal_alter; coder_upgrade.call.inc, coder_upgrade.function.inc, coder_upgrade.regex.inc: Add these files; coder_upgrade.call.inc: drupal_add_css, drupal_add_js, drupal_set_html_head, filter_formats: revised.
• #703506 by hctom: move static variable out of hook implemenation into calling routine
• #698054 by hctom - patch to shorten cache keys and add hook_flush_caches().
• main.inc: Implement new parser routines - reader, writer::getInstance; reader::reset.
• #689758 by solotandem: Fix code so it runs in 7.x-alpha 1.
• #690518 by linclark: api.php, help.inc, inc, install: Use second person tense in document comments.
• #688424 by chx: coder_upgrade.main.inc: Replace require_once statements with call to module_load_include (that includes DRUPAL_ROOT).
• #685144 by toddy: fixed typo in name of _coder_review_7x_hook_profile_alter_warning function.
• #666714 by dereine: Fixed parameters in coder_review_drush_help().
• coder_upgrade.other.inc: Grammar Parser changes: T_RETURN statements changed from array to PGPExpression, body statements changed from PGPList to PGPBody.
• Refactor: move functions from main to list, module to main; improve on setting module name; change debug echo to print; use second person tense in document comments.
• #615786 by cedarm: Update according to hook_theme api changes.
• Upgrade schema_html and schema_ret.
• Switch order of invocation between functions and function calls; bug fix on theme() upgrade.
• Upgrade hook_node and hook_nodetype (part of the remove_op item).
• Upgrade hook_user (part of the remove_op item) and user_cancel.
• Upgrade hook_comment (part of the remove_op item).
• Upgrade hook_block (part of the remove_op item).
• Upgrade install-schema; refactor function upgrade routines to work from a PGPNode object.
• Refactor user_authenticate.
• Upgrade actions_synchronize and url_is_external.
• Refactor upgrade routines for drupal_http_request, format_plural, module_invoke, t, taxonomy_get_tree and theme function calls.
• Upgrade rename-drupal-to-js and drupal_add_js_weight; refactor drupal_add_js_options.
• #651844: coder_upgrade_module_name (no module file in directory).
• Wrap patch file contents with check_plain.
• Turn off debugging code; fix coder_upgrade_module_name function.
• Upgrade filter_urls.
• Upgrade theme_changes.
• Upgrade user_authenticate.
• Upgrade locale_context; utilize API changes.
• Upgrade filter_formats_parameters.
• Upgrade drupal_add_js_options.
• Upgrade hook_menu_link_alter, book_toc.
• Upgrade hook_update_N.
• Upgrade hook_schema.
• Update hook_perm.
• Initial function updates using the parser; Update hook_access.
• Add documentation examples of using grammar parser API functions; Rename PGPFunctionCall2 to PGPFunctionCall; Upgrade module_invoke with respect to taxonomy_get_tree.
• Upgrade moved_statistics_settings and drupal_set_title.
• Upgrade drupal_execute and drupal_http_request.
• Store module name in global variable; add function to echo debug output.
• Reenable upgrade functionality as code has been updated to reflect the refactored grammar parser API.
• Code change to incorporate refactored grammar parser API.
• Begin commit of code changes to incorporate refactored grammar parser API.
• Changes due to revised core api or standards: third person tense in hook_x comments, manually include files again; Change settings menu path; Disable upgrade functionality until grammar parser refactoring is complete.
• updated links.
• #565610 by snufkin - t and format_plural context arguments change
• Added a coder_review_test module for aiding testing of items that can't be done in a .test file.
• #565280 by snufkin - added optional block module review, removed rolled back unit tests
• #569990 by matason, snufkin - added d6 to d7 review for hook_profile_alter() change
• #583136 by willmoy, matason - added 'case' to list of keywords not to enforce no space between it and (
• #471874 by grendzy - added dependency on drush
• #575726 - changed coder_review module description
• #607592 by japerry: - changed menu paths. - updated arguments to theme() function calls and definitions. - changed drupal_add_css/js calls to use #attached instead. - changed #markup theme() calls to use #theme. - coding style fixes. - added CHANGELOG.txt files
• #565318 by snufkin: Changed hook_user() was completely removed.
• #588874 by David_Rothstein: Fixed change from #input_format() to #text_format() not complete.
• by sun: Speeding up Coder tests by 8 percent.
• #570478 by matason, sun: Updated for removed registry.
• #571086 by sun: Updated for new function signature for form builder callbacks.
• #583734: Revert drupal_function_exists to function_exists.
• by matason - check for hook_node_access change
• fix theming of columns
• doh! actually, select count(*) is valid, but in some cases you might not want to use it
• do not use select count(*)
• fix $tmprule
• implement rule file for module_list() and module_implements()
• #565156 by snufkin - coder review for hook_filter()
• #565160 by rfay - coder review for #ahah changed to #ajax
• changed module paths
• Convert class attributes to array in favor of a string
• rolled back drupal_function_exists() and xmlrpc reviews
• fixed api d7 changes
• Change calls to file_check_directory to file_prepare_directory in light of core function rename.
• Implement more conversion routines using the PGP API and regular expressions.
• Implement initial batch of conversion routines using the PGP API.
• Group conversion routines by processing order (beginning, middle, or end). Separate middle conversion routines into two groups (regex and parser) to utilize the PGP API. Add handler specification (regex or parser) for the middle changes applied at the file level. Revise API documentation.
• added in comments
• fix for #filename element
• additional d6 to d7 reviews
• renamed some functions to avoid false matches
• changed #filename and #filename-not to include the \. so it's not added by core coder.module to the regex. additional d6 to d7 reviews.
• additional reviews
• additional d6 to d7 reviews
• added in check_plain() to prevent js code from executing
• fixed 'implements hook_foo()' review
• js d6 to d7 changes
• fixed summary error count
• fixed parsing of non php files, and a few d6 to d7 changes
• removed deprecated @ selector
• Additional d6 to d7 reviews
• additional d6 to d7 api reviews, esp node api changes.
• Rename hook_perm and the permission; Revise API documentation.
• Create log file and patch files; Add links to log file and patch files in user interface; Revise help text; Revise api.php file.
• Revise user interface using new D7 form elements; implement hook_upgrades; revise help text.
• Apply D7 standards for naming forms and implement hook comments; revise help text.
• additional d6 to d7 reviews
• d6 to d7: taxonomy_get_tree review
• added in new d6 to d7 reviews
• added hook_perm d6 to d7 review
• added in more d6 to d7 reviews
• #448524 by brianV - added review for drupal_execute() function rename.
• Initial commit of coder upgrade module (without any conversion routines).
• Added in some missing links and a missing test for node_invoke_nodeapi().
• Added in a few new links from categorized 6.x to 7.x reviews.
• Fixed @see reviews.
• More 6x to 7x patches.
• Fixed php notice warning.
• #454386 by Dave Reid - fix for getInfo() can not be called statically error.
• #483288 by Dave Reid - fix for drupal_get_page() warning.
• menu description change
• #477336 - changed menu definitions.
• #477336 - fix coder settings page not appearing.
• Improved patch reviewing - class and filename matching wasn't working.
• Fix for different patch format parsing.
• allow for -> in oo function names in @see comments.
• @see review fix
• comment review changes
• updated file list.
• Replaced coder_review_comment.inc with a proper set of simpletests.
• Fixed warning doc links, again.
• #467862 - fix for documentation links being broken.
• #271028 by douggreen, jcnventura - coder no longer tests for camelCase in classes.
• made changes for drupal_get_form() and menu changes.
• #246568 - D7 string concatenation rule changes
• string concatenation tweaks
• #466934 by John Morahan - fix for empty lines added in patches being lost.
• #455722 - changed t() to dt()
• Fixed issue with false positives on core include files.
• Split internationalization review into two separate files - one for reviewing php functions are correctly implemented, etc, and one for reviewing the translation files themselves.
• Fixed warning for when no translated string is available.
• More 6x to 7x reviews.
• comment status changes for d7
• #399974 - by chiddicks, path fixing
• More coder 7x reviews
• rule / tests for 'Parameters for actions_synchronize() have changed'
• Added in time() tests, and path 'user/logout' ones.
• Added REQUEST_TIME vs time() rule
• Fixed bug with false positives.
• Made it so coder's assertCoderReviewFail() and assertCoderReviewPass() lines are ignored as they contain code that is invalid.
• Fixed paths.
• logout path change in D7
• Added more files.
• More tweaks.
• Fixes to coder 7x api rules / tests
• Rule tweak
• Fixed upgrade rules.
• Fixed paths.
• Fixed menu path issues - by robeano
• initial D6 to D7 reviews by smokris
• Changed menus.
• Fixed issue where some simpletests failed because #filename-not included test files.
• Removed coder.install - no functions needed in it.
• Few bug fixes.
• coder re-org
• Putting images back
• Remove images.
• Fixed some string concatenation rules / tests.
• incorrect path fix.
• Drupal 7 port.
• Removed some trailing spaces.
• by sun: Fixed boolean constants must be written uppercase.
• #360766 by sun: Fixed missing space for parameter to break statement.
• #246568 by sun: Updated for new string concatenation standard.
• #272089 by sun: Fixed outdated installation instructions for coder_format tests.
• rework tests to get better line numbers on pass/fail
• upgrade simpletests to the 6.2 framework
• fix some of the tests
• fix the simpletest system so that the tests are returning (hopefully) correct results, but now many of the tests are broken
• finish upgrading style tests to simpletest
• #308412 - fix false positive on l(check_plain( ... and also reorganize tests a little
• better handling for missing files
• Syncing HEAD with latest code in DRUPAL-6--1.
• add check for schema api
• add rule for confirm form submit redirect FAPI change
• add warning about $form[op]
• fix check for dependencies
• change link for drupaldocs on menu system
• fix php E_ALL error
• #107453 - make the coder link on the system admin page more visible
• fix sorting by line numbers
• minor word change
• implement check for indentation of 2 spaces
• #157581 - bug found by Steven - only look for trailing ?> outside quotes
• updating coder_6x review with links to drupal documentation
• add support for rules #link
• set code background in descriptions - getting ready to update the coder_6x review with more help
• fix bugs found while reviewing 6.x
• style updates found while reviewing 6.x
• add new core modules to list of core modules
• more 6.x porting
• check for .info core= line
• fix check for #function
• more 6x upgrade rules
• fix check for last modified time
• get coder working again on 6.x head (more)
• get coder working again on 6.x head
• #152819: Module .info files should not define 'version' in CVS
• #148417 - display statistics about number of files and errors
• don't use hook_init - this was inefficient (init'd on every page) and prevents code from running with aggressive caching installed, refactoring this code actually made it simpler too!
• remove $Id check from coder_style (it's now in coder_comment)
• #150619 - fix check for ?>
• sort the modules and themes in the selection form
• sort the review names in the selection form
• add 'comment' #source and implement first rules for comments
• add core = 6.x
• fix function check check .install files
• update rules from DRUPAL-5 tag
• fix additional E_ALL error
• coder re-upgraded to current version of 6.x (CVS HEAD)
• update rule for cache_set
• port 5.x updates to 6.x
• #140150 - the space is optional before a heredoc name
• update url() and l() warning message again
• change url() and l() warning link to actual script
• improve 6.x upgrade script to detect url() and l() args
• #121388 by sun - fix bug in _coder_search_string
• fix 5.x upgrade .info warning
• add #function to regex processing to limit searches to a function
• adding coder_6x upgrade review
• adding images to HEAD
• add "language" to the global variables
• remove 5.x menu code from HEAD/6.x branch
• update to work with 6.x theme registry and hook_form_alter changes
• copying DRUPAL-5 to HEAD for D6 development
• #126938 by sun - add coder_format script to be distributed with cod coder_format implements an alternative solution to formatting source code
• *** empty log message ***
• switch colors for normal and minor
• add css styling to severity levels;
• add css styling to severity levels; fix bug that displayed 'minor' warnings when level was 'normal' or higher;
• add coder.js
• #114711 - implement rule severity and user option
• significant UI improvements that: moves the settings form to coder page display of warnings in fieldsets
• copy from D5 branch and add experimental UI using forms
• #109386 from webchick - add link to warning about info files; fix t() with links per http://api.drupal.org/api/HEAD/function/t;
• oops, info file values using CVS ids must be in strings because the $ is not understood by parse_ini_file
• add link to XHTML standard on lowercase
• change functions coder_drupal_* to coder_style_ (to support name change).
• Finish moving includes/tests to tests and coder_drupal.inc to coder_style.inc
• #107914 by moshe weitzman - add back to Development group
• #107448 - add <<< processing; add rules for
  and uppercase XHTML; move includes/tests to tests and move coder_drupal.inc coder_style.inc;
• #108849 reported by add1sun - because coder was not properly handling multi-line quotes, had to significantly overhaul the parsing, which should be more accurate and much faster now, and also adds the capability to check html.
• #108870 reported by add1sun - 0xFF is not camelCase
• not my night - one more change to affect menu change from admin/coder to coder
• replace all paths with coder instead of admin/coder
• #107434 from webchick - move from admin/coder menu to coder
• #107638 reported by webchick - fix <?xml?> false positive
• Fix #107642 that was introduced by the fix to #107391 - proper display of links in warnings
• #107644 from webchick - improve $_POST['op'] warning
• Fix #107444 from webchick - only perform regex rules on php, not html - skip characters between ?> <?php
• Fix #107617 reported by oadaeh - display multiple errors from same line
• Fix #107598 - oops, broke this earlier today with #107172 fix.
• #107607 from webchick - remove redundant permissions check
• #107430 from webchick - allow globals defined in the Drupal 5 modules directory
• #107391 by webchick - Display relevant line of code with error. I reworked the patch and added an option setting to disable. Thanks for suggesting this, it's a great addition!
• #107389 - minor info file corrections
• fix #107172 - if the user supplied argument was not a valid module, it performed a review of every .inc file under the Drupal directory - a major system hog, to say the least
• fix the ?> warning; add an api reference to t() in another warning;
• implement better stdclass rule; fixed case-insensitive check that was accidentally removed; started a tests folder and added a couple of style tests
• stdClass is in, StdClass is out... http://drupal.org/node/106585
• fix rules in drupal coding standards: 1. camelcase should allow stdClass - http://drupal.org/node/106585 2. allow global variable names from core 3. fix check for extra spaces between the function name and parenthesis added #not rule to facilitate above
• remove #case option, instead use regex (?-i) for case sensitive matches
• better handling of multi-line strings that will allow us to catch errors on the same line as the trailing quote.
• handle multi-line strings - http://drupal.org/node/106493
• thanks to yched! fixing the string concatenation rule http://drupal.org/node/106411
• update README to reflect current state of the project
• use php variable functions for version specific function usage (cleaner code requires only one usage of the function and is less likely to be buggy).
• Use sentence capitalization instead of Case Capitalization
• fix php4 error - http://drupal.org/node/106097
• improve rule warning's to include links to the approriate drupal api functions; this is actually a major overhaul of the rule warning system -- implementing a #warning_callback option and moving the t() processing out of the rule.
• add rule for theme_add_style
• better comment about my break from the string concatenation style suggestion
• Add rule for string concatenation; Look for a space before function names so we have fewer false positives;
• fix quote/string processing to handle escaped quotes
• Add TODO comment (this is the source of the false positives in coder_47.inc)
• alter theming of results with link to full results page on summary page; fix false warning; fix misspelled word;
• implemented Drupal 4.6 -> 4.7 review
• changed do_coder_review args to array for more flexibility; added upgrade50 check for .info file
• Add initial Drupal 5 review; Update include plug-in formatting;
• Fix default review values
• display partial paths
• fix php pass-by-ref deprecate warning by using call_user_func_array()
• Backout attempt to display partial paths, because of bugs
• support 4.7 and 5 with single code base
• Remove unnecessary unset
• Fix _coder_default_reviews to return checked status
• Tighten up the logic for finding includes, avoiding getting entries outside of the file subpath
• Doh again (too RAD) - restore rules commented out during testing
• Implement camel case check
• Doh! Remove test case!
• Add #original tag to distinguish between using $lines and $orig_lines; Add security warning about $REQUEST_URI
• Let preg_replace handle array of lines when possible; Replace quoted strings with empty strings, to avoid false positives
• Add curly braces rule; Fix drupal callback to use new comment argument
• Fix bug in new comment processing; Add a few more Drupal coding styles; Remove #coder_ignore in preparation for better string handling
• Strip comments so we get fewer false positives
• don't handle includes when doing the full list -- it takes too long fix display of <? ?> in coder_drupal.inc
• Prevent processing of same include file more than once
• Perform code review on include files Add #coder_ignore directive Remove ?> from include files
• Add for to control structures list Look for trailing ?> (probably unnecessary because CVS strips this from modules)
• Link to coder page from coder module settings
• adding first cut at security
• Add first cut at security callback (not functional at all)
• Sort warnings by line number
• Theming changes
• Implement most of Drupal Coding standards
• Theme coder_line Minor mods to rule definitions getting ready for other types
• add link to system_modules form add access denied message to page