Problem/Motivation
Hi,
On #3437555: Use tagged iterators for the MR 15, PHPCS on Gitlab CI is green. But when I execute it locally with the following configuration https://gitlab.com/florenttorregrosa-drupal/docker-drupal-project/-/blob... I obtain the following error message:
FILE: project/app/modules/custom/entity_access_password/src/Plugin/Field/FieldType/EntityAccessPasswordItem.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | An error occurred during processing; checking has been aborted. The error message was: Tags support is not enabled. Enable the "Yaml::PARSE_CUSTOM_TAGS" flag to use "!tagged_iterator" at line 13
| | (near "!tagged_iterator entity_access_password_password_validator").
| | The error originated in the DrupalPractice.Objects.GlobalDrupal sniff on line 102.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
I can't figure out why it is working on Gitlab and not locally.
I asked for help on Slack https://drupal.slack.com/archives/CGKLP028K/p1719307342557139
Also there not able to figure out why.
Steps to reproduce
root@619b79f9dbef:/project# composer show | awk '$0 ~ /codesniffer|coder|coding-standard|variable-analysis/ {print $1 " " $2}';
clue/ndjson-react 1.3.0
dealerdirect/phpcodesniffer-composer-installer 1.0.0
drupal/coder 8.3.24
sirbrillig/phpcs-variable-analysis 2.11.18
slevomat/coding-standard 8.15.0
squizlabs/php_codesniffer 3.10.1
Drupal Core: 10.3.0
PHP: 8.3.6
Remaining tasks
Identify the root cause.
Thanks for any help.
Comments
Comment #2
grimreaperSo I showed the bug to @klausi, and it is definitely a real bug.
I will provide a PR with the fix on Github and we need to a failing test.
Comment #3
grimreaperFix + tests PR: https://github.com/pfrenssen/coder/pull/230
Tests only PR: https://github.com/pfrenssen/coder/pull/231
Ready for review.
Comment #4
fjgarlin commentedThe code and the new test looks good, but I'm not familiar with the testing or process for this project, so I'll leave to somebody else RTBC.
Comment #5
grimreaperComment #7
klausimerged, thanks!