Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.As a follow-up for #2222435: Add a sniff to ensure @todo comments follow the coding standards, in Core the new sniff gives
--------------------------------------------------------------
A TOTAL OF 167 ERRORS AND 0 WARNINGS WERE FOUND IN 124 FILES
--------------------------------------------------------------
Most, if not all, should be able to get fixed automatically. There will also be many in Contrib and a fixer will save hours of developer time.
Comments
Comment #2
adamzimmermann CreditAttribution: adamzimmermann at Chromatic commentedComment #3
adamzimmermann CreditAttribution: adamzimmermann at Chromatic commentedMade some progress on this yesterday. Hoping to sort out the remaining issues today.
Comment #4
adamzimmermann CreditAttribution: adamzimmermann at Chromatic commentedPR ready with tests and code style checks passing locally.
https://github.com/pfrenssen/coder/pull/123
Comment #5
Arkener CreditAttribution: Arkener as a volunteer commentedThank you!, I've left some feedback on your PR.
Comment #6
adamzimmermann CreditAttribution: adamzimmermann at Chromatic commentedNew PR created to fix commit history and address feedback.
https://github.com/pfrenssen/coder/pull/125
Comment #8
klausiMerged, thanks!
Comment #9
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedNice work @adamzimmermann.
Now we can raise a core issue to fix these. Previously I have started the issue before the new version of Coder is used in core, and used a patch to add the new sniff. We could do that again, as it will be a while before Core 9.2 starts using Coder 8.3.11 (especially is this version does not exist yet)
Comment #10
klausiI'm planning to release Coder 8.3.11 after #3177757: InlineVariableComment fix breaks on commented var block is done.
Comment #11
adamzimmermann CreditAttribution: adamzimmermann at Chromatic commentedCore issue created. I'm hoping to get it sorted out shortly.
https://www.drupal.org/project/drupal/issues/3180696
Comment #12
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedAdded core issue as related.
Comment #13
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedAh, I did not see you have already referenced this from the other end.
Comment #14
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedNow I'm confused. This issue no longer appears in the Core one. Adding back.
Comment #15
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedSorry for the noise. Got it wrong due to old form data changing the status.