When I upgraded my site to latest COD release (2.x), I noticed that footer started breaking on session pages. There were a few other style variations as well but footer was very different. With DOM inspector, I noticed that additional styles were being applied to this page by hydra.css. I eventually traced hydra.css to the Hydra layout in Pisces theme. I disabled the Pisces theme but the styles were still applied.
On looking at hydra.scss, I saw that it is including all the styles for the theme (via _glob.scss). I think this is wasteful. The layout css should only include styles for that layout.
An argument can be made that if I am using the Hydra layout, my theme should inherit Pisces as well, but I don't think that's true. For one thing, Panels still loaded the layout even though the theme was disabled. For another, layout is more towards site building and it is always better to have it decoupled from the theme. Take Panels' default layouts for an example.
Remove theme specific components from _glob.scss and include it for theme's css files.
- Decide on the approach.
- Write a patch
- Review
- Commit
Comments
Comment #1
hussainwebCorrection: Panels does not load the layouts if the theme is disabled. Now I wonder if the layouts should be part of theme, especially since they are used by default on session pages (and maybe others). My original issue still stands. I still think the layout's css could be independent of the theme's css.