The recent merged patches/MRs appear to have broken dev. Installing dev branch results in the following error:

ParseError: Unmatched '}' in Drupal\Core\Extension\Extension->load() (line 633 of modules/custom/coc_forms_auto_export/coc_forms_auto_export.module).

and removing the unmatched } results in another error:

ParseError: syntax error, unexpected token "public" in Composer\Autoload\{closure}() (line 142 of modules/custom/coc_forms_auto_export/src/Element/AutoExportExcludedColumns.php).

so I think this needs looking at again. I'm going to create a new branch based on the last working version with the D10 patch and see how I get on.

Issue fork coc_forms_auto_export-3472520

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

welly created an issue. See original summary.

sarwan_verma’s picture

sarwan_verma commented
Assigned: Unassigned » sarwan_verma
welly’s picture

welly commented
Status: Active » Needs review

Have created an initial merge request that looks like it's working (although there are other issues that need investigation which can be done in a different issue). I'll need to merge in the coding standards work and check that doesn't break anything.

welly’s picture

welly commented

Updated MR with coding standards fixes

welly opened merge request !8

welly’s picture

welly commented

I've had to revert a few of the commits so known, working patches could be reapplied and so I think this is probably a good starting place for ongoing development.

welly’s picture

welly commented
Assigned: sarwan_verma » Unassigned

If this can be reviewed, it'd be much appreciated! Or at least my approach discussed. We'll probably have to revisit https://www.drupal.org/project/coc_forms_auto_export/issues/3259009 and https://www.drupal.org/project/coc_forms_auto_export/issues/3286562 but it'll get the dev branch in a working state.

welly’s picture

welly commented
Status: Needs review » Closed (outdated)

Work is being done on a new 3.x branch to bring the module up to date.